Conversation
Make things compile with polkadot v0.9.32. Please note that certain things are just commneted out and will be fixed/improved in upcoming commits.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
==========================================
+ Coverage 91.53% 91.57% +0.04%
==========================================
Files 93 93
Lines 21765 21845 +80
==========================================
+ Hits 19923 20005 +82
+ Misses 1842 1840 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Chralt98
left a comment
There was a problem hiding this comment.
LGTM.
Just wanted to mention this #936 .
Both try-runtime migration tests checked ✅ .
Client connects to old nodes ✅ .
I get this test failure:
failures:
---- integration_tests::xcm::tests::transfers::transfer_roc_to_relay_chain stdout ----
thread 'integration_tests::xcm::tests::transfers::transfer_roc_to_relay_chain' panicked at 'assertion failed: `(left == right)`
left: `999988806429`,
right: `948894198216`', runtime/battery-station/src/integration_tests/xcm/tests/transfers.rs:238:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
My command was: cargo test --all-features
Interesting, seems the test script didn't consider all features. Fixed in #1006. In regards to the failing tests: XCM instruction weights have been improved, see this and this (diff here). Equally true for Polkadot. Mismatching fees fixed in 6f82f9a |
Upgrade from 0.9.29 to 0.9.32 fixes #927
Notable PR
paritytech/substrate#11649 (has migrations)
paritytech/polkadot#6091
paritytech/substrate#11981
https://github.com/paritytech/substrate/pull/12109/files
Summary of changes
pre_upgradenow returns a vector of bytes that can be used inpost_upgrade(deprecatesget/set_temp_storage)Originis now replaced byRuntimeOriginCallis now replaced byRuntimeCall