Skip to content

Update ubuntu version for docker Hadolint#1442

Merged
Chralt98 merged 1 commit intomainfrom
chralt98-fix-docker-hub
Jul 7, 2025
Merged

Update ubuntu version for docker Hadolint#1442
Chralt98 merged 1 commit intomainfrom
chralt98-fix-docker-hub

Conversation

@Chralt98
Copy link
Copy Markdown
Member

@Chralt98 Chralt98 commented Jul 7, 2025

What does it do?

image

Our current CI workflow for docker has a problem. More on that here.

This PR updates the ubuntu version of the runner to from 20.04 to 22.04.

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

Summary by CodeRabbit

  • Chores
    • Updated the workflow environment for automated checks to use Ubuntu 22.04.

@Chralt98 Chralt98 requested review from robhyrk and saboonikhil July 7, 2025 12:54
@Chralt98 Chralt98 self-assigned this Jul 7, 2025
@Chralt98 Chralt98 added the s:review-needed The pull request requires reviews label Jul 7, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 7, 2025

Walkthrough

The GitHub Actions workflow configuration was updated, changing the execution environment for the "hadolint" job from Ubuntu 20.04 to Ubuntu 22.04. No other modifications were made to the workflow's steps or job definitions.

Changes

File(s) Change Summary
.github/workflows/docker-hub.yml Updated "hadolint" job to use Ubuntu 22.04 runner.

Poem

A hop to Ubuntu twenty-two,
For linting Docker, fresh and new.
The workflow’s path, a subtle tweak,
Ensures our builds are strong, not weak.
With every run, a smoother flow—
The rabbit’s job is good to go! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28e6eaf and 621f625.

📒 Files selected for processing (1)
  • .github/workflows/docker-hub.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Checks (clippy)
  • GitHub Check: Checks (standalone)
  • GitHub Check: Coverage
  • GitHub Check: Test parachain build
  • GitHub Check: Checks (parachain)
  • GitHub Check: Format
  • GitHub Check: Quick check benchmarks
  • GitHub Check: Test standalone build
  • GitHub Check: Fuzz
  • GitHub Check: Summary
🔇 Additional comments (1)
.github/workflows/docker-hub.yml (1)

11-11: Upgrade to ubuntu-22.04 looks good—confirm image/toolchain compatibility
The runner bump should unblock the failing job. Please trigger a manual workflow or build the Dockerfile locally on 22.04 to ensure no package-version surprises (e.g., apt sources or GCC/GLIBC mismatches).


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (28e6eaf) to head (621f625).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1442   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         181      181           
  Lines       34625    34625           
=======================================
  Hits        32334    32334           
  Misses       2291     2291           
Flag Coverage Δ
tests 93.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Jul 7, 2025
@Chralt98 Chralt98 merged commit 57001b9 into main Jul 7, 2025
24 checks passed
@Chralt98 Chralt98 deleted the chralt98-fix-docker-hub branch July 7, 2025 13:15
@coderabbitai coderabbitai bot mentioned this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s:accepted This pull request is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants