ruby: Disable Ruby LSP for ERB files #41754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ruby extension uses the `solargraph` language server by default for Ruby files. However, when a user opens any ERB file, the extension automatically starts the Ruby LSP. This affects developers because they do not expect the Ruby LSP to be running.
cla-bot
bot
added
the
cla-signed
This was referenced Nov 3, 2025
|
@vitallium I wonder if this is going to be breaking features like this: Shopify/ruby-lsp-rails#659 /cc @janko |
Yes, it will break such things, so we need to document how to enable Ruby LSP in |
|
Since I already have to explicitly enable |
P1n3appl3
pushed a commit
to bnjjj/zed
that referenced
this pull request
Nov 4, 2025
The Ruby extension uses the `solargraph` language server by default for Ruby files. However, when a user opens any ERB file, the extension automatically starts the Ruby LSP. This affects developers because they do not expect the Ruby LSP to be running. Closes zed-extensions/ruby#172 Release Notes: - N/A
osiewicz
pushed a commit
that referenced
this pull request
Nov 5, 2025
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
maxbrunsfeld
pushed a commit
that referenced
this pull request
Nov 6, 2025
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
maxbrunsfeld
pushed a commit
that referenced
this pull request
Nov 6, 2025
Hi, this is a follow-up change for #41754 I think it important to keep existing things working. So add notes to the Ruby extension doc about enabling Ruby LSP for ERB files as well. Thanks! Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby extension uses the
solargraphlanguage server by default for Ruby files.
However, when a user opens any ERB file,
the extension automatically starts the Ruby LSP.
This affects developers because
they do not expect the Ruby LSP to be running.
Closes zed-extensions/ruby#172
Release Notes: