languages: Add inline values support for JavaScript, TypeScript, and TSX #40914
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @taciclei on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @taciclei on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
|
We require contributors to sign our Contributor License Agreement, and we don't have @superman32432432 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
cla-bot
bot
removed
the
cla-signed
taciclei
force-pushed
the
feature/js-ts-inline-values
branch
from
13cd533 to
d180369
Compare
cla-bot
bot
added
the
cla-signed
taciclei
force-pushed
the
feature/js-ts-inline-values
branch
from
d180369 to
483e4a3
Compare
This commit adds debugger.scm files and tests for JavaScript, TypeScript, and TSX languages to enable inline variable value display during debugging sessions. The implementation uses Tree-sitter queries to capture: - Variable declarations (var, let, const) - Function parameters (regular, arrow, destructured) - Object and array destructuring patterns - Loop variables (for, for-in, for-of, while) - Try-catch error variables - Class fields and methods - Lexical scopes (blocks, functions, classes) Added comprehensive tests in debugger_ui covering: - JavaScript inline values - TypeScript inline values with types - Arrow functions - Destructuring patterns Release Notes: - Added inline variable value display during debugging for JavaScript, TypeScript, and TSX. Variable values now appear inline in the editor while debugging.
taciclei
force-pushed
the
feature/js-ts-inline-values
branch
from
bb6e407 to
6b61766
Compare
|
Btw some of the inline value tests are failing right now, CI won't pass until they're passing |
… TSX Simplified debugger.scm patterns to match Rust/Python approach: - Capture variable declarations and expression usages - Remove function parameters and call arguments capture - Add support for binary/unary expressions, returns, arrays, objects - Add JSX expression support for TSX Updated test expectations to match actual inline values behavior. All 11 inline values tests now pass.
The .scm queries in these files usually has the name of the comment in the query itself, thus making these comments redundent
|
In the future if you're going to vibe code a PR please
|
2 participants
Summary
This PR adds debugger inline values support for JavaScript, TypeScript, and TSX languages. This enables variable values to be displayed inline in the editor during debugging sessions, similar to existing support for Rust, Python, and Go.
Changes
Added
debugger.scmTree-sitter query files for:crates/languages/src/javascript/debugger.scm)crates/languages/src/typescript/debugger.scm)crates/languages/src/tsx/debugger.scm)These query files capture:
Implementation Details
The implementation follows the same pattern as existing debugger support in other languages:
Testing
Tested with various JavaScript/TypeScript code patterns including:
Release Notes: