-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Propagate Jupyter client errors #40886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate Jupyter client errors #40886
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @lionel- on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for coming in to make this better.
|
It looks like you need to run |
oops sorry about that, for some reason format-on-save wasn't working. Now fixed! |
|
Thanks! Nice to see someone using this stuff :D |
yep there are some R users in Zed! What the R community would really like though is a console-based workflow, e.g. https://fosstodon.org/@josi/115448105735120564 I'm hoping that one day users will be able to opt into their preferred workflow for Zed's Jupyter client, either inline output in editors or console/terminal output. Thanks for merging! |
Closes #40884
Resultkernel_errored()(which is already used to report process crashes)Screen.Recording.2025-10-22.at.13.28.36.mov
This is not perfect. I did not have time to look into this but:
But at least the user is getting feedback on what went wrong.
Release Notes: