Skip to content

Conversation

@lionel-
Copy link
Contributor

@lionel- lionel- commented Oct 22, 2025

Closes #40884

  • Make IOPub task return a Result
  • Create a monitoring task that watches over IOPub, Control, Routing and Shell tasks.
  • If any of these tasks fail, report the error with kernel_errored() (which is already used to report process crashes)
Screen.Recording.2025-10-22.at.13.28.36.mov

This is not perfect. I did not have time to look into this but:

  • When such errors happen, the kernel should be shut down.
  • The kernel should no longer appear as online in the UI

But at least the user is getting feedback on what went wrong.

Release Notes:

@cla-bot
Copy link

cla-bot bot commented Oct 22, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @lionel- on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@lionel-
Copy link
Contributor Author

lionel- commented Oct 22, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 22, 2025
@cla-bot
Copy link

cla-bot bot commented Oct 22, 2025

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Member

@rgbkrk rgbkrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for coming in to make this better.

@rgbkrk
Copy link
Member

rgbkrk commented Oct 24, 2025

It looks like you need to run cargo fmt as well

Diff in /home/runner/work/zed/zed/crates/repl/src/kernels/native_kernel.rs:3:
     AsyncBufReadExt as _, SinkExt as _,
     channel::mpsc::{self},
     io::BufReader,
-    stream::{SelectAll, StreamExt, FuturesUnordered},
+    stream::{FuturesUnordered, SelectAll, StreamExt},
 };

@lionel-
Copy link
Contributor Author

lionel- commented Oct 28, 2025

It looks like you need to run cargo fmt as well

oops sorry about that, for some reason format-on-save wasn't working. Now fixed!

@ConradIrwin ConradIrwin enabled auto-merge (squash) October 28, 2025 14:31
@ConradIrwin
Copy link
Member

Thanks! Nice to see someone using this stuff :D

@ConradIrwin ConradIrwin merged commit 3248a05 into zed-industries:main Oct 28, 2025
22 checks passed
@lionel-
Copy link
Contributor Author

lionel- commented Oct 28, 2025

Nice to see someone using this stuff :D

yep there are some R users in Zed!

What the R community would really like though is a console-based workflow, e.g. https://fosstodon.org/@josi/115448105735120564

I'm hoping that one day users will be able to opt into their preferred workflow for Zed's Jupyter client, either inline output in editors or console/terminal output.

Thanks for merging!

@lionel- lionel- deleted the bugfix/propagate-kernel-errors branch October 28, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jupyter client errors are not propagated to the UI

4 participants