Skip to content

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Oct 21, 2025

We were spawning the process on the foreground thread before which can block an arbitrary amount of time. Likewise we no longer block deserialization on the terminal loading.

Release Notes:

  • Improved startup time on systems with slow process spawning capabilities

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 21, 2025
@Veykril Veykril force-pushed the lw/terminal-async branch 2 times, most recently from 1a60dbb to 5224ada Compare October 21, 2025 11:47
@Veykril Veykril marked this pull request as ready for review October 21, 2025 11:50
@Veykril Veykril changed the title project: Spawn terminal process on background thread project: Spawn terminal process on background executor Oct 21, 2025
@Veykril Veykril force-pushed the lw/terminal-async branch 2 times, most recently from 970da4d to ea0ec48 Compare October 21, 2025 12:10
@Veykril Veykril force-pushed the lw/terminal-async branch 2 times, most recently from 13b527d to 51c8605 Compare October 21, 2025 12:49
@Veykril Veykril enabled auto-merge (squash) October 21, 2025 13:08
@Veykril Veykril merged commit 0eccdfe into main Oct 21, 2025
23 checks passed
@Veykril Veykril deleted the lw/terminal-async branch October 21, 2025 13:10
agu-z added a commit that referenced this pull request Oct 23, 2025
agu-z added a commit that referenced this pull request Oct 23, 2025
Reverts #40774 and
#40824 since they introduce a
bug where Nushell processes are leaked and Ctrl+C doesn't kill the
current process.

Release Notes:

- Fix a bug where nushell processes wouldn't get killed after closing a
terminal tab
JosephTLyons pushed a commit that referenced this pull request Oct 24, 2025
Reverts #40774 and
#40824 since they introduce a
bug where Nushell processes are leaked and Ctrl+C doesn't kill the
current process.

Release Notes:

- Fix a bug where nushell processes wouldn't get killed after closing a
terminal tab
Veykril added a commit that referenced this pull request Oct 26, 2025
Split out from #40774 to
reduce the size of the reland of that PR (once I figure out the cause of
the issue)

Release Notes:

- N/A *or* Added/Fixed/Improved ...
Veykril added a commit that referenced this pull request Oct 26, 2025
We were spawning the process on the foreground thread before which can
block an arbitrary amount of time. Likewise we no longer block
deserialization on the terminal loading.

Release Notes:

- Improved startup time on systems with slow process spawning
capabilities
Veykril added a commit that referenced this pull request Oct 30, 2025
Attempt 2 for #40774

We were spawning the process on the foreground thread before which can
block an arbitrary amount of time. Likewise we no longer block
deserialization on the terminal loading.

Release Notes:

- Improved startup time on systems with slow process spawning
capabilities
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
Split out from zed-industries#40774 to
reduce the size of the reland of that PR (once I figure out the cause of
the issue)

Release Notes:

- N/A *or* Added/Fixed/Improved ...
tomatitito pushed a commit to tomatitito/zed that referenced this pull request Nov 7, 2025
…s#41216)

Attempt 2 for zed-industries#40774

We were spawning the process on the foreground thread before which can
block an arbitrary amount of time. Likewise we no longer block
deserialization on the terminal loading.

Release Notes:

- Improved startup time on systems with slow process spawning
capabilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants