project_panel: Fix buffer focus when canceling filename edit #40747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter to cancel_edit function
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
smitbarmase
requested changes
Oct 21, 2025
Member
smitbarmase
left a comment
smitbarmase
left a comment
There was a problem hiding this comment.
I think we should default to confirm as same as VSCode. This was recently changed in #39716.
Contributor
Author
|
Got it sounds good! |
SO9010
changed the title
Contributor
Author
|
Alright that should have sorted that, I had a draft where it confirmed rather than cancelled. I didn't quite know what to call the pr so please feel free to change that! |
smitbarmase
approved these changes
Oct 22, 2025
Member
smitbarmase
left a comment
smitbarmase
left a comment
There was a problem hiding this comment.
Looks great! I removed the global focus out handling since the filename editor’s blur event already covers confirm behavior, making that redundant. Thanks for working on this.
smitbarmase
changed the title
Contributor
Author
|
Awesome thank you so much! I am very happy to start my contributions to zed!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37726
Release Notes: