Fix the project diff sometimes missing updates #40662
Merged
+214
−159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two related things:
RepositoryEvent::Updatedin favor of three new events that have clearer definitions:BranchChanged,StashEntriesChanged, andStatusesChanged. An implication of this is that we no longer emit aRepositoryEventunless some git state changed; previously we would emitRepositoryUpdatedafter doing a git status scan even if no statuses changed.GitStore, so it relied on getting aGitStoreEventwhen some buffer's diff hunks changed, even if the git status of the buffer's file didn't change (e.g. a second hunk in a file that was already modified). After this PR, it also subscribes to the individualBufferDiffentities for buffers that have a git status, so theGitStoreis freed from that responsibility. This also fixes some real cases where the previous strategy was not effective in keeping the project diff up to date (captured in a test).Release Notes: