Skip to content

Conversation

@bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Oct 10, 2025

Closes #24670

(Follow up of #36856) cc @ConradIrwin Thanks for your help

Release Notes:

Fixed: Keep non project files when filtering in File finder

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 10, 2025
@zed-industries-bot
Copy link

zed-industries-bot commented Oct 10, 2025

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- Added/Fixed/Improved ...

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against 38d1032

@maxdeviant maxdeviant changed the title file_finder: display single files already opened file_finder: Display single files already opened Oct 10, 2025
@SomeoneToIgnore
Copy link
Contributor

Seems that the original issue has a beautiful set of steps to repro:

image

Cannot we add a test based on that?

bnjjj added 2 commits October 14, 2025 11:51
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
@bnjjj
Copy link
Contributor Author

bnjjj commented Oct 14, 2025

@SomeoneToIgnore I wrote a test and confirmed it was failing before my fix

Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for adding a test!

Have left a small style remarks, will merge the PR after tomorrow's release to have more time to test this: curious if there are any "unexpected" single files this brings up.

@bnjjj
Copy link
Contributor Author

bnjjj commented Oct 15, 2025

Done. Thanks for the review

@SomeoneToIgnore SomeoneToIgnore merged commit ce2259c into zed-industries:main Oct 15, 2025
22 checks passed
@djrenren
Copy link

Thanks so much for fixing this 🙏

P1n3appl3 pushed a commit to P1n3appl3/zed that referenced this pull request Oct 18, 2025
Closes zed-industries#24670

(Follow up of zed-industries#36856) cc
@ConradIrwin Thanks for your help

Release Notes:

Fixed: Keep non project files when filtering in File finder

---------

Signed-off-by: Benjamin <[email protected]>
Co-authored-by: Kirill Bulatov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File Finder forgets open buffers when filtering

4 participants