Skip to content

Conversation

@huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Oct 2, 2025

Release Notes:

  • Improved text color in LSP document color highlight.

Because highlight ranges are implemented using a paint background, there's no way to control the text color.

I've been thinking about this problem for a long time, want to solve it.

Today, I come up with a new idea. Re-rendering the document color text at the top should solve this problem.

Update 10/6:

The previous version is not good, when we have soft wrap text, that version will not work correct.

Now use exists bg_segments_per_row feature to fix text color.

Before

image

After

image

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 2, 2025
@huacnlee huacnlee marked this pull request as draft October 2, 2025 14:34
@huacnlee huacnlee marked this pull request as ready for review October 2, 2025 14:59
@huacnlee huacnlee marked this pull request as draft October 6, 2025 03:53
@huacnlee huacnlee marked this pull request as ready for review October 6, 2025 06:23
@JosephTLyons
Copy link
Collaborator

Thanks for the PR @huacnlee - we'll get this reviewed shortly!

@JosephTLyons JosephTLyons removed the request for review from mikayla-maki October 6, 2025 15:45
@smitbarmase smitbarmase merged commit d7ffc37 into zed-industries:main Oct 21, 2025
22 checks passed
@smitbarmase
Copy link
Member

Thank you, @huacnlee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants