language_models: Fix tool calling for x-ai/grok-code-fast-1 model via OpenRouter
#37094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
imumesh18
changed the title
imumesh18
changed the title
x-ai/grok-code-fast-1 model via OpenRouter
imumesh18
changed the title
x-ai/grok-code-fast-1 model via OpenRouterx-ai/grok-code-fast-1 model via OpenRouter
imumesh18
changed the title
x-ai/grok-code-fast-1 model via OpenRouterx-ai/grok-code-fast-1 model via OpenRouter
SomeoneToIgnore
added
the
area:ai
Contributor
|
Works for me! Thank you @imumesh18. |
notpeter
pushed a commit
that referenced
this pull request
Aug 28, 2025
…ia OpenRouter (#37094) Closes #37022 Closes #36994 This update ensures all Grok models use the JsonSchemaSubset format for tool schemas. A previous fix for this issue was too specific, only targeting grok-4 models. This caused other variants, like grok-code-fast-1, to be missed. We've now broadened the logic to correctly apply the setting to the entire Grok model family. Release Notes: - Fix tool calling for `x-ai/grok-code-fast-1` model via OpenRouter.
notpeter
pushed a commit
that referenced
this pull request
Aug 28, 2025
…ia OpenRouter (#37094) Closes #37022 Closes #36994 This update ensures all Grok models use the JsonSchemaSubset format for tool schemas. A previous fix for this issue was too specific, only targeting grok-4 models. This caused other variants, like grok-code-fast-1, to be missed. We've now broadened the logic to correctly apply the setting to the entire Grok model family. Release Notes: - Fix tool calling for `x-ai/grok-code-fast-1` model via OpenRouter.
tidely
pushed a commit
to tidely/zed
that referenced
this pull request
Sep 10, 2025
…ia OpenRouter (zed-industries#37094) Closes zed-industries#37022 Closes zed-industries#36994 This update ensures all Grok models use the JsonSchemaSubset format for tool schemas. A previous fix for this issue was too specific, only targeting grok-4 models. This caused other variants, like grok-code-fast-1, to be missed. We've now broadened the logic to correctly apply the setting to the entire Grok model family. Release Notes: - Fix tool calling for `x-ai/grok-code-fast-1` model via OpenRouter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37022
Closes #36994
This update ensures all Grok models use the JsonSchemaSubset format for tool schemas.
A previous fix for this issue was too specific, only targeting grok-4 models. This caused other variants, like grok-code-fast-1, to be missed. We've now broadened the logic to correctly apply the setting to the entire Grok model family.
Release Notes:
x-ai/grok-code-fast-1model via OpenRouter.