rust: Improve highlighting within macros #37049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
MrSubidubi
added a commit
that referenced
this pull request
Sep 3, 2025
Follow-up to #37049 This fixes an issue where we would lose highlighting in derive macros if one of the names was qualified. | Before | After | | --- | --- | | <img width="886" height="398" alt="Bildschirmfoto 2025-09-03 um 10 39 25" src="https://github.com/user-attachments/assets/dbc680e3-6ce3-4059-9934-9daa4c59d4a0" /> | <img width="886" height="398" alt="Bildschirmfoto 2025-09-03 um 10 38 14" src="https://github.com/user-attachments/assets/6e10df6f-5158-4bfd-81ab-8f2b384f1e99" /> | Release Notes: - N/A
tidely
pushed a commit
to tidely/zed
that referenced
this pull request
Sep 10, 2025
This makes sure we do not apply the highlights for snake case identifiers as well as paths for attributes too broadly to all types of macros, which should make macros much more readable overall whilst keeping the highlighting for the attribute items. | Before | After | | --- | --- | | <img width="1414" height="958" alt="Bildschirmfoto 2025-08-28 um 00 37 58" src="https://github.com/user-attachments/assets/1254b9a2-d07a-4be4-9b4f-555a7c640302" /> | <img width="1414" height="958" alt="Bildschirmfoto 2025-08-28 um 00 37 38" src="https://github.com/user-attachments/assets/5f6dd66c-5469-4f27-9f1d-0a6e6e8d8085" /> | Release Notes: - rust: Improved highlighting within macros.
tidely
pushed a commit
to tidely/zed
that referenced
this pull request
Sep 10, 2025
Follow-up to zed-industries#37049 This fixes an issue where we would lose highlighting in derive macros if one of the names was qualified. | Before | After | | --- | --- | | <img width="886" height="398" alt="Bildschirmfoto 2025-09-03 um 10 39 25" src="https://github.com/user-attachments/assets/dbc680e3-6ce3-4059-9934-9daa4c59d4a0" /> | <img width="886" height="398" alt="Bildschirmfoto 2025-09-03 um 10 38 14" src="https://github.com/user-attachments/assets/6e10df6f-5158-4bfd-81ab-8f2b384f1e99" /> | Release Notes: - N/A
FrGoIs
pushed a commit
to FrGoIs/zed
that referenced
this pull request
Sep 29, 2025
This makes sure we do not apply the highlights for snake case identifiers as well as paths for attributes too broadly to all types of macros, which should make macros much more readable overall whilst keeping the highlighting for the attribute items. | Before | After | | --- | --- | | <img width="1414" height="958" alt="Bildschirmfoto 2025-08-28 um 00 37 58" src="https://github.com/user-attachments/assets/1254b9a2-d07a-4be4-9b4f-555a7c640302" /> | <img width="1414" height="958" alt="Bildschirmfoto 2025-08-28 um 00 37 38" src="https://github.com/user-attachments/assets/5f6dd66c-5469-4f27-9f1d-0a6e6e8d8085" /> | Release Notes: - rust: Improved highlighting within macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure we do not apply the highlights for snake case identifiers as well as paths for attributes too broadly to all types of macros, which should make macros much more readable overall whilst keeping the highlighting for the attribute items.
Release Notes: