Inlay hints on hover #36875
Closed
Inlay hints on hover #36875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cole Miller <[email protected]>
When hovering over an inlay hint, point_for_position.as_valid() returns None because inlays don't have valid text positions. This was causing hover_at(editor, None) to be called, which would hide any active hovers. The fix is simple: don't call hover_at when we're over an inlay position. The inlay hover is already handled by update_hovered_link, so we don't need to do anything else.
This reverts commit e7c6f22.
This reverts commit 0d6232b.
This reverts commit 0bb1a5f.
Co-authored-by: David Kleingeld <[email protected]>
Co-authored-by: David Kleingeld <[email protected]>
Co-authored-by: David Kleingeld <[email protected]>
Co-authored-by: David Kleingeld <[email protected]>
Co-authored-by: David Kleingeld <[email protected]>
Co-authored-by: David Kleingeld <[email protected]>
Co-authored-by: David Kleingeld <[email protected]>
Co-authored-by: David Kleingeld <[email protected]>
cla-bot
bot
added
the
cla-signed
Co-authored-by: David Kleingeld <[email protected]>
rtfeldman
force-pushed
the
inlay-hint-merged
branch
from
365b004 to
78ca73e
Compare
Co-authored-by: Richard Feldman <[email protected]>
Contributor
|
I'm about to merge #40183 today which will make inlays' caching quite different, so seems that this PR has to be re-landed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE
Release Notes: