Implement Helix match mode (m i and m a)
#35687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
romaninsh
force-pushed
the
helix-match-mode
branch
2 times, most recently
from
6fddd38 to
49a55d8
Compare
romaninsh
force-pushed
the
helix-match-mode
branch
from
49a55d8 to
3258d25
Compare
Contributor
|
Oh no what about my #34060? Only took me until now, while you did this impressively fast I believe 😅 |
Contributor
Author
|
Sorry, I missed it entirely. This looks really good TBH and amazing that even though I'm new to zed, our implementation look similar. I try to ship in small incremental improvements. I can pick this apart. 👍 |
SomeoneToIgnore
assigned
ConradIrwin and
SomeoneToIgnore and unassigned
ConradIrwin and
SomeoneToIgnore
Member
|
I'm going to close this for now as it conflicts horribly; but I think we do want this feature. @fantacell do you know when you'll get time to work on #34060 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #33906
Resolves: #32020
Resolves: #31997
Merge after: #35612, #35611, #35501, #35468
This PR re-uses vim's operator logic to implement Helix "match" mode.
m iandm awork well across all existing objects with some tweaks around paragraphs.Release Notes:
v vno longer drop you into Normal mode out of HelixNormalm iandm aThe gist of this PR here: 3258d258c87aa20135ad4490ead424ebb59e76be
Bugs: