Add tab close buttons #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll use this in the mouse event handler to track hover and click state.
Still need to give elements the ability to re-render their parent view. Once that is in place, I think we can implement hoverable close tab buttons.
Co-Authored-By: Antonio Scandurra <[email protected]>
Co-Authored-By: Max Brunsfeld <[email protected]>
Co-Authored-By: Max Brunsfeld <[email protected]>
This provides the sampler with a bit more data when positioning sprites at subpixel positions. Co-Authored-By: Antonio Scandurra <[email protected]>
Co-Authored-By: Antonio Scandurra <[email protected]>
Co-Authored-By: Antonio Scandurra <[email protected]>
…g a scene This ensures that we correctly update the hover state of elements whose position has changed relative to the mouse cursor even though the mouse hasn't actually moved. Co-Authored-By: Antonio Scandurra <[email protected]> Co-Authored-By: Max Brunsfeld <[email protected]>
1 task
Anthony-Eid
pushed a commit
to Anthony-Eid/zed
that referenced
this pull request
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
MouseEventHandlerthat tracks whether the element is hovered or clicked and relays this state to anFnOnceso it can be used to inform the appearance of element.MouseEventHandlerdepends on a newValueHandlefacility that I added toAppContext. Value handles allow mouse handler elements with the same id to store and retrieve ephemeral state across different frames. This is needed because elements are reconstructed on every frame.This PR adds: