Skip to content

Conversation

@alessandrobrunoh
Copy link
Contributor

@alessandrobrunoh alessandrobrunoh commented Sep 9, 2025

@cla-bot

This comment was marked as resolved.

@alessandrobrunoh

This comment was marked as resolved.

@alessandrobrunoh

This comment was marked as resolved.

@cla-bot

This comment was marked as resolved.

@cla-bot

This comment was marked as resolved.

@alessandrobrunoh

This comment was marked as resolved.

@cla-bot cla-bot bot added the cla-signed label Sep 10, 2025
@cla-bot

This comment was marked as resolved.

Copy link
Contributor

@notpeter notpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple things you'll need to fix this:

  1. You need to add your extension id/version to extensions.toml
  2. You need to sort the gitmodules/extensions.toml (use pnpm run sort-extensions)
  3. You need to to edit extension.toml in your repo. Remove these lines (they are what was supposed to go in extensions.toml (note the S):
    https://github.com/alessandrobrunoh/zed-grammar-jdl/blob/f21f2832a15c34382fe145187f825af49e392016/extension.toml#L13-L15
  4. Pull forward the submodule commit to include those changes.

@alessandrobrunoh
Copy link
Contributor Author

Ohhh I forgot, I'll do it when I get home thanks

@alessandrobrunoh
Copy link
Contributor Author

@notpeter i think i did everything, let me know if i have to edit something else. Thanks

@notpeter

This comment was marked as resolved.

@notpeter notpeter changed the title Add zed-grammar-jdl submodule Add jdl language extension Sep 10, 2025
@alessandrobrunoh
Copy link
Contributor Author

@notpeter done. Sry, its my first time publishing an extension but i wanna try to pub more, and maybe contribute to Zed too. xD

@alessandrobrunoh
Copy link
Contributor Author

@notpeter

@notpeter notpeter merged commit 456bee3 into zed-industries:main Sep 23, 2025
3 checks passed
@notpeter
Copy link
Contributor

Thanks. Apologies for the delay.

lucascompython pushed a commit to lucascompython/extensions that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants