Support while keyword in rt.postgres grammar#256
Conversation
- Registered `:while` op in `rt.postgres.grammar/+features+`. - Added `pg-while-block` in `rt.postgres.grammar.form-let` to handle AST transformation. - Added `block-while-block` in `rt.postgres.grammar.common` to emit PL/pgSQL `WHILE ... LOOP ... END LOOP;`. - Added unit test in `rt.postgres.grammar.form-let-test`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Implemented
whileloop support for thert.postgresDSL. This allows(while (condition) ...)forms to be correctly compiled intoWHILE condition LOOP ... END LOOP;SQL statements. This required updating the grammar definition, adding a new form transformer, and implementing the emission logic. Existing tests pass, and a new test case verifies the transformation.PR created automatically by Jules for task 2853174932864141328 started by @zcaudate