Skip to content

Add repo files to help maintain conventions #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add repo files to help maintain conventions #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7580373
Add repo files to help maintain conventions
AArnott Sep 8, 2023
8629e5f
Address PR comments
AArnott Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# EditorConfig is awesome:http://EditorConfig.org

# top-most EditorConfig file
root = true

[*]
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true

[*.sh]
indent_size = 4

[*.json]
indent_size = 2

[*.css]
indent_size = 2
7 changes: 7 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
###############################################################################
# Set default behavior to automatically normalize line endings.
Copy link
Collaborator

@daira daira Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set default behavior to automatically normalize line endings.
# Set default behaviour to not attempt to normalize line endings.

Copy link
Contributor Author

@AArnott AArnott Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behavior is the US English spelling of the word. Is there a policy to use British English in the repo?

###############################################################################
* text eol=lf
Copy link
Collaborator

@daira daira Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* text eol=lf
* -text

Copy link
Contributor Author

@AArnott AArnott Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This policy states that you don't mind a mix of line endings. Within a file, line endings could be mixed (and you can blame the editor if you want), but certainly newly introduced files may be created with CRLF line endings. This policy that you propose should mean you're OK with that.
If you want to see LF line endings instead, we should state that.


# Ensure shell scripts use LF line endings (linux only accepts LF)
*.sh eol=lf