Skip to content

Add progress logging to the basic CLI view. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuttycom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add progress logging to the basic CLI view. #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/commands/wallet/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,20 @@ fn scan_blocks<P: Parameters + Send + 'static>(
Ok(true)
}
Ok(_) => {
if let Some(summary) = db_data.get_wallet_summary(0)? {
info!(
Copy link
Collaborator

@str4d str4d Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we don't log this if we are in the TUI view, as its log window is limited.

"Scan complete for range {}; progress is {}/{}",
scan_range,
summary.progress().scan().numerator()
+ summary.progress().recovery().map_or(0, |p| *p.numerator()),
summary.progress().scan().denominator()
+ summary
.progress()
.recovery()
.map_or(0, |p| *p.denominator()),
)
}

// If scanning these blocks caused a suggested range to be added that has a
// higher priority than the current range, invalidate the current ranges.
let latest_ranges = db_data.suggest_scan_ranges()?;
Expand Down
Loading