Skip to content

Conversation

@gmmajal
Copy link
Contributor

@gmmajal gmmajal commented Dec 5, 2025

Relevant issue: #109

Background info: # any relevant background info for additional context, references to documentations etc.

  • Previously, we were only considering the default rules enabled by Ruff.
  • We should expand them to include some of the rules mentioned here: https://docs.astral.sh/ruff/linter/.

Changes introduced: # list changes to the code repo made in this pull request

  • Added new linting rules for Ruff in the pyproject.toml file.
  • Fixed a trailing whitespace and a url inside the README.

@gmmajal gmmajal self-assigned this Dec 5, 2025
@gmmajal gmmajal marked this pull request as draft December 5, 2025 10:43
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (42798a1) to head (806cd9e).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          943       940    -3     
=========================================
- Hits           943       940    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmmajal
Copy link
Contributor Author

gmmajal commented Dec 8, 2025

Additional changes:

  • Fix linting issues (mostly associated with "isort" rules) using the command ruff check --fix. It changed the order in which the modules are written inside scripts.

@gmmajal gmmajal requested a review from annakasprzik December 8, 2025 09:38
@gmmajal gmmajal marked this pull request as ready for review December 8, 2025 09:38
Copy link
Contributor

@annakasprzik annakasprzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@gmmajal gmmajal merged commit 26e529a into zbw:master Dec 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants