V2 group read file not found error#2480
Closed
will-moore wants to merge 4 commits intozarr-developers:mainfrom
Closed
V2 group read file not found error#2480will-moore wants to merge 4 commits intozarr-developers:mainfrom
will-moore wants to merge 4 commits intozarr-developers:mainfrom
Conversation
Contributor
Author
|
There are a lot of test failures above, but it looks like my test passed! |
Closed
Member
|
This PR fixes about 100 failures in https://github.com/ome/ome-zarr-py/pull/404/files#diff-d51ad4cb28d657d5e09c58f40674b95273611983353ab5d7bb2049bbc6303f7b ; I've fixed the merge conflict and approved the workflows. 🤞🏽 that it goes green. |
Member
|
Looks like fixing the merge conflict led to: |
Contributor
Author
|
Thanks @joshmoore. Updating my test, looks like it passes without the fix in this PR, so it seems to have been fixed elsewhere. Closing for now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to fix an issue I reported at #2412 (comment)
which is causing a lot of test failures when updating ome-zarr-py to use zarr v3 at ome/ome-zarr-py#404
TODO: