Changed the outdated twitter logo#105
Changed the outdated twitter logo#105AquibKhann wants to merge 2 commits intozarr-developers:mainfrom AquibKhann:fixes2_twitterBug
Conversation
|
Thanks for sending the PR, @AquibKhann. Upon visiting https://zarr-developersgithubio--105.org.readthedocs.build/en/105/ and scrolling to the bottom, the Twitter (X) logo is not visible. |
|
working on it |
|
I have done the changes in the config.yml file but still the change is not being reflected. Did I need to make changes on some other files aswell ? can you please guide me . |
|
Maybe this will work: https://fontawesome.com/icons/x-twitter?f=brands&s=solid? |
|
Thanks ! let me try |
|
I am unable to setup the environment for running the Zarr on my machine due to some security constraint I will make it happen by tomorrow , can you tell me whether new PR make the changes visible or not . |
|
?? |
|
You can see the build under https://zarr-developersgithubio--105.org.readthedocs.build/en/105/ or by going to the job link: |
|
We were not using the current Font-awesome version that is why we were not able to see the changes . Zarr.-.Google.Chrome.2024-02-16.10-41-39.mp4 |
|
Nice catch, @AquibKhann. |
|
I wanted to push but unfortunately I was not able to locate the file in which the CDN of Font Awesome is present .It might be hidden . Can you help me out ? |
|
?? |
|
I think you'd need to edit the In the minimal mistakes repo, I can only see the old versions of the Twitter logo (check here; the logos are this and this). This is why the new logos are not rendering properly. Also, the zarr-developers.github.io repository doesn't fork the Minimal Mistakes repo. Instead, we're using the theme as a remote theme. Let me know if there are more questions. |
|
I was facing some issues to setup the environment so that I can run the site on my machine i.e why I deletd the fork and wanted to start from zero. |
|
can you please help me out on how can I set up the environment on my machine |


closes #104
This pull request addresses the outdated Twitter logo issue by replacing it with a more current and visually consistent icon. The new Twitter icon has been sourced from a licensed and suitable provider to ensure compliance with project licensing requirements.