Skip to content

Conversation

@prokopyl
Copy link
Member

@prokopyl prokopyl commented Dec 16, 2020

This PR does the following:

This fixes #41.
This fixes #42.
This fixes #43.

@prokopyl prokopyl added the M ⋅ Outdated Bukkit API Miscelaneous – Tracks removal of deprecated/outdated/useless code due to a newer Bukkit API label Dec 16, 2020
@prokopyl prokopyl added this to the v0.1 milestone Dec 16, 2020
@prokopyl prokopyl self-assigned this Dec 16, 2020
@prokopyl prokopyl removed the request for review from AmauryCarrade December 17, 2020 00:05
@prokopyl prokopyl force-pushed the proper-dualwielding branch from e1516a8 to 41bfbae Compare December 17, 2020 10:48
@prokopyl prokopyl force-pushed the proper-dualwielding branch from 41bfbae to 005674d Compare December 17, 2020 13:02
Copy link
Member

@AmauryCarrade AmauryCarrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! Only thing: missing changelog update. At least:

  • added ItemUtils.consumeItemInOffHand;
  • moved ItemUtils.consumeItem to ItemUtils.consumeItemInMainHand;
  • moved ItemUtils.damageItemInHand to ItemUtils.damageItem;
  • ItemUtils.damageItem now returns true if the damaged item was broken;
  • moved ItemUtils.breakItemInHand methods to InventoryUtils.breakItemInHand;
  • moved DualWielding to InventoryUtils.DualWielding;
  • moved DualWieldling methods to InventoryUtils;
  • removed DualWieldling.setItemInHand and DualWieldling.getItemInHand (use Bukkit API instead).

@AmauryCarrade AmauryCarrade requested a review from Vlammar April 11, 2021 16:51
@AmauryCarrade AmauryCarrade merged commit 1b952ea into master Apr 11, 2021
@AmauryCarrade AmauryCarrade deleted the proper-dualwielding branch April 11, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M ⋅ Outdated Bukkit API Miscelaneous – Tracks removal of deprecated/outdated/useless code due to a newer Bukkit API

Projects

None yet

4 participants