Remove reflection-based DualWielding implementation, and update related utilities #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
DualWieldingreflection-based utility class since all methods are now in Bukkit (as discussed in Remove reflection-based DualWielding implementation #43)DualWielding.getHoldingHand()method toInventoryUtilsItemUtils.breakItemInHand()methods toInventoryUtils, as they are more related to inventories than itemsDualWieldingenum toInventoryUtils, now as a simple enum representing the handsItemUtils.consumeItem()toItemUtils.consumeItemInMainHandandItemUtils.consumeItemInOffHand(as discussed in ItemUtils: Update consumeItem to support dual-wielding #41)ItemUtils.damageItemInHand()toItemUtils.damageItem(), and update it to use theDamageableAPI (see ItemUtils: Update damageItemInHand to use the Damageable ItemMeta API #42)This fixes #41.
This fixes #42.
This fixes #43.