Added methods to ItemUtils to convert from a material family and a color to a material #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmauryCarrade
added
B ⋅ Waiting for another PR
AmauryCarrade
removed
the
B ⋅ Waiting for another PR
AmauryCarrade
force-pushed
the
quartzlib-est-désormais-une-artiste---elle-a-découvert-la-peinture-et-elle-aime-ça
branch
from
5ed13e8 to
0edd5d2
Compare
As we don't have any way to get a colorized version from a color and a base material (like, get Material.BLUE_BED from BED and BLUE, both of them being dynamic), here are methods to do so.
- Added tests - Added checkstyle config to allow to suppress warning through annotation
AmauryCarrade
force-pushed
the
quartzlib-est-désormais-une-artiste---elle-a-découvert-la-peinture-et-elle-aime-ça
branch
from
0edd5d2 to
3ba85ed
Compare
Member
Author
|
Ready for review. |
prokopyl
requested changes
Nov 26, 2020
Member
prokopyl
left a comment
prokopyl
left a comment
There was a problem hiding this comment.
Only one minor suggestion, otherwise lgtm 👍
prokopyl
approved these changes
Nov 26, 2020
prokopyl
deleted the
quartzlib-est-désormais-une-artiste---elle-a-découvert-la-peinture-et-elle-aime-ça
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
I'm not sure about the enum name and the external or internal state of it.
Also we should add tests, I'm not sure how many.Done.This PR depends on #62 and was based on its branch so we can test this (that's why we can see its commits here). Tests not passing are normal, they're the ones from #62.#62 is merged and the PR was rebased.