将配置项 admin_https 的作用域限制到 /admin*#5498
Merged
jxlwqq merged 4 commits intoz-song:masterfrom Jan 5, 2022
zhaojjiang:master
Merged
将配置项 admin_https 的作用域限制到 /admin*#5498jxlwqq merged 4 commits intoz-song:masterfrom zhaojjiang:master
jxlwqq merged 4 commits intoz-song:masterfrom
zhaojjiang:master
Conversation
配置项的名称是 admin_https，那么该配置的作用域不应该超出 /admin* 的范围，即不应该去影响非后台路由，一旦这里影响了，后续想要在其他页面做 http 和 https 的兼容会很麻烦
jxlwqq
requested changes
Jan 5, 2022
jxlwqq
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
配置项的名称是 admin_https，那么该配置的作用域不应该超出 /admin* 的范围，即不应该去影响非后台路由，一旦这里影响了，后续想要在其他页面做 http 和 https 的兼容会很麻烦