[Test] All drops on L2 interface HLD

[yvolynets-mlnx]

No description provided.

[liat-grozovik]

I asked during the meeting on Thursday to have a table with the different drops and which group it is related and to define which we are going to test. i dont see this table

[liat-grozovik]

you control the traffic, you should make it correct IMO From: yvolynets-mlnx <notifications@github.com> Sent: Monday, October 28, 2019 2:37 PM To: yvolynets-mlnx/SONiC <SONiC@noreply.github.com> Cc: Liat Grozovik <liatg@mellanox.com>; Comment <comment@noreply.github.com> Subject: Re: [yvolynets-mlnx/SONiC] [Test] All drops on L2 interface HLD (#2) @yvolynets-mlnx commented on this pull request.

________________________________ In doc/SONIC_Test_Ingress_Discard_All_HLD.md<#2 (comment)>:

+The "ingress_discard_all" counter counts all discard events. This counter counts concurrently with other discard counters.

+The test assumes all necessary configuration are already pre-configured on the SONIC switch before test runs. +Destination IP address of the injected packet must be routable to ensure packet should be routed but was dropped. + +#### Scope +The purpose of the test is testing of "ingress_discard_all" counter triggering on SONIC system, making sure that specific traffic drops correctly, according to sent packet and configured packet discards. +Supported topologies: +``` +t0 +t1 +t1-lag +ptf32 +``` + +#### Related DUT CLI commands +Command to check "ingress_discard_all" counter value: It can be checked, but as it also will increase for "errors", this verification some times can be incorrect. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#2?email_source=notifications&email_token=AKTABA6BX5K7LC6SQSOBHTLQQ3MIDA5CNFSM4JFX3KFKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJMOOCA#discussion_r339539422>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABA243VAI6RVS223U3LLQQ3MIDANCNFSM4JFX3KFA>.

[volodymyrsamotiy]

Is it possible to add short description for all drop reasons for each test case?

[volodymyrsamotiy]

Could you please change "ingress_discard_all" name to something more specific in the last step for each test case? (this step: " Verify "ingress_discard_all" counter increment")
For example use SONiC name of appropriate counter or just describe by words, because current name is confusing and it looks like a name of some attribute but in fact it isn't.

[liat-grozovik]

Can you also provide prio for implementation in the table?
For example p1 is few from ethernet and few from IP. p2, etc.