Conversation
yuazhe
force-pushed
the
fix_base
branch
4 times, most recently
from
0ebc97e to
3866866
Compare
sonic-net#3009 breaks the number base rule, treats the page number CLI input as decimal rather than hex, this is used to fix it. it also containes a redundancy function definition, so remove it. Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
keboliu
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
sonic-net#3009 breaks the number base rule, treats the page number CLI input as decimal rather than hex, this is used to fix it.
it also contains redundancy function definition, so remove it.
How I did it
add the number conversion
How to verify it
unit test and manually test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)