-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[YouTube] Update extractor for 2025-04, etc #33109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* in particular, support `only_once` in the same methods
* support exists_ok parameter in Py < 3.2
* use compat_os_makedirs * support non-ASCII characters in cache key * improve logging
* only 1..100: yt-dlp/yt-dlp#11130
* thx coletdjnz, bashonly: yt-dlp/yt-dlp#12777
* no longer required for these cases
* ... where defined
* thx seproDev, bashonly: yt-dlp/yt-dlp#12760, yt-dlp/yt-dlp#12761: - Improve nested attribute support - Pass global stack when extracting objects - interpret_statement: Match attribute before indexing - Fix assignment to array elements with nested brackets - Add new signature tests - Invalidate JS function cache - Avoid testdata dupes now that we cache by URL * rework nsig function name search * fully fixes ytdl-org#33102 * update cache required versions * update program version
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boilerplate: own+yt-dlp code/bug fix+improvement
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
The main object of this PR is to update the Youtube extractor to handle the latest players and improve compatibility with yt-dlp:
esc_rfc3986()encoding cache keys, for Py2/3 compat!Perhaps too long delayed, the program version is updated.
Rolled in are these changes:
compat_os_makedirs()InfoExtractorvariants for remaining parent method callsThx to relevant contributors per commit messages.