-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix npo support #31976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bartbroere
wants to merge
68
commits into
ytdl-org:master
Choose a base branch
from
bartbroere:fix-npo-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix npo support #31976
Changes from 4 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
3b31478
Fix support for NPO downloads
bartbroere b4776f2
Import from compat
bartbroere fb2b4e2
Add line comment
bartbroere 9e1acb2
Fix flake8
bartbroere 6328978
Accept suggestions on PR; comply with conventions
bartbroere 0c7261d
Update npo.py
dirkf c409a8c
Merge branch 'ytdl-org:master' into fix-npo-support
bartbroere f76d58c
Skip a test
bartbroere da3d1f4
Add notes on new npo.nl site
bartbroere 5773681
Fix token URL
bartbroere 29724e7
Delete all broken extractors
bartbroere 21eb451
Convert the description into code
bartbroere 0dc7d95
Comply with coding conventions a bit more
bartbroere fb7b717
Speculate about other ways of getting productId
bartbroere f9e59b0
Add the possibility to add 'hls' later
bartbroere 8b1a7d9
Use provided util
bartbroere 34b5b20
Refactor into reusable method
bartbroere 4fc4238
Fix lint
bartbroere 28ba01f
Add Ongehoord Nederland and test URL for BNNVARA
bartbroere eb6e396
First version of a VPRO regex
bartbroere d36d50f
Re-add Zapp
bartbroere d426a92
Encoding suggestion from PR
bartbroere 3b3d73c
Use program-detail endpoint and remove a test
bartbroere 4b24e5f
Re-add SchoolTV
bartbroere 681b390
Fix flake8 and better error reporting
bartbroere 159f825
Add scaffolding for last few extractors and change order so the PR di…
bartbroere 0cbcd1a
Make diff better
bartbroere 0ab79c3
Reusable code for two NTR sites
bartbroere c08f29f
Update unit tests
bartbroere 28624cf
Work work
bartbroere 1ca4e68
Add an MD5
bartbroere 4398f68
Fix zapp extractor
bartbroere 58d7a00
Resolve some of the pull request feedback
bartbroere d4250c8
Merge branch 'ytdl-org:master' into fix-npo-support
bartbroere ad64f37
Improve regex
bartbroere bc86c5f
Make regex more specific and remove redundant .*
bartbroere 4c90b2f
Adhere to code style
bartbroere 007bbea
Remove afspelen and trailing slashes with one regex
bartbroere a60972e
Fix indent from suggestion
bartbroere 179c8b0
Merge branch 'ytdl-org:master' into fix-npo-support
bartbroere ad6ee6f
Commit two suggestions from the PR
bartbroere bf91db4
Use suggested util
bartbroere 6de650f
Use traverse_obj in another place as well
bartbroere c748eca
Automatically obtain NextJS buildId and change item to video-item
bartbroere 41157b2
Move GraphQL query into separate variable
bartbroere c3026dd
Apply suggestion from PR
bartbroere 7f1c09b
Use _sort_formats util
bartbroere 0e1a0cf
Apply some more PR feedback
bartbroere 817e2e5
Fix some missing imports
bartbroere 75266ce
Fix old metadata reference
bartbroere 6f27142
Update tests
bartbroere 224e0a7
Merge branch 'ytdl-org:master' into fix-npo-support
bartbroere 4aa57d6
Merge remote-tracking branch 'ytdl-org/master' into fix-npo-support
bartbroere 91e279f
Fix name of key
bartbroere 1fe43de
Merge remote-tracking branch 'ytdl-org/master' into fix-npo-support
bartbroere 4f8b323
Merge remote-tracking branch 'ytdl-org/master' into fix-npo-support
bartbroere 0a61173
Merge remote-tracking branch 'ytdl-org/master' into fix-npo-support
bartbroere 82d496f
Merge remote-tracking branch 'ytdl-org/master' into fix-npo-support
bartbroere c4e5b23
Merge remote-tracking branch 'ytdl-org/master' into fix-npo-support
bartbroere 35857bf
download_webpage() without _handle
dirkf 8611871
Take the first result without breaking from a loop
bartbroere 8fd477c
Match HTML tags
bartbroere 958f9aa
Merge remote-tracking branch 'ytdl-org/master' into fix-npo-support
bartbroere 0d1fa41
Fix variable name and add capture group to regex
bartbroere 2de603b
Fix test that is no longer available
bartbroere 2f1c1f0
Add new test for BNNVara site if the resource is a simple mp4 URL
bartbroere dce0e96
Don't get a handle if we don't use it
bartbroere d763512
Fix flake8
bartbroere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.