Skip to content

Conversation

@AobaIwaki123
Copy link
Contributor

Description

I fixed the problem in devcontainer.json related to #3170

1. Remove redundant filed

{
	"name": "Youki",
-	"extensions": [
-		"rust-analyzer"
-	],

2. Fix configuration format

-				"rust-analyzer.checkOnSave.command": "clippy"
+				"rust-analyzer.check": {
+					"command": "clippy"
+				}

3. Replace deprecated extension with new one

			"extensions": [
				"vadimcn.vscode-lldb",
				"mutantdino.resourcemonitor",
				"rust-lang.rust-analyzer",
				"tamasfe.even-better-toml",
-				"serayuzgur.crates"
+				"fill-labs.dependi"
			]

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

Fixes #3170

Additional Context

@AobaIwaki123 AobaIwaki123 force-pushed the fix-dev-container-settings branch from d45d3e7 to 6fc32df Compare May 24, 2025 04:59
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution!

@utam0k utam0k added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug labels Jun 7, 2025
@utam0k utam0k merged commit 54a070b into youki-dev:main Jun 7, 2025
26 of 34 checks passed
@github-actions github-actions bot mentioned this pull request Jun 7, 2025
@AobaIwaki123 AobaIwaki123 deleted the fix-dev-container-settings branch June 7, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "extensions" field in devcontainer.json is redundant and has a deprecated extension

2 participants