Skip to content

Conversation

@YJDoc2
Copy link
Collaborator

@YJDoc2 YJDoc2 commented Apr 2, 2025

Description

This fixes few issues with the current exec command implementation

  • This uses PATH from original spec if it is not explicitly specified for the exec. Currently exec simply fails if PATH is not given, and users have to manually give PATH for exec command. This will use PATH from original spec by default
  • This passes on uid, gid and additional gids provided to exec command. Currently we accept these args, but simply ignore them ; because of which we cannot exec into the container with specific uid/gid. With this fix, proper uid/gid will be used.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

Related Issues

Fixes #3069 , Fixes #2756

Additional Context

N/A

@YJDoc2 YJDoc2 added the kind/bug label Apr 2, 2025
@YJDoc2 YJDoc2 requested a review from a team April 2, 2025 12:05
@utam0k utam0k self-assigned this Apr 8, 2025
@YJDoc2 YJDoc2 force-pushed the fix/exec_cmd_fixes branch from 0f558bb to 4ab1eed Compare April 21, 2025 12:29
@utam0k utam0k merged commit 30d0b9b into youki-dev:main Apr 23, 2025
56 of 59 checks passed
@github-actions github-actions bot mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to Use ping in Busybox Container Created with Youki (Root User) runc differences given the same config.json

2 participants