-
Notifications
You must be signed in to change notification settings - Fork 392
bump nix to 0.29.0 #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump nix to 0.29.0 #3123
Conversation
Signed-off-by: Keming <[email protected]>
Signed-off-by: Keming <[email protected]>
|
Hye @kemingy Thanks for the PR. overall looks good to me as no major code changes ; so should be good to merge if all CI passes. Strange that dependabot did not notify us for this. I guess I closed a PR for nix few versions ago due to breaking changes in nix, and dependabot must be ignoring all minor version updates due to that ; will need to see how we can fix it. As you have mentioned that this is to be used in a project (seems pretty cool!) I would like to clarify that I'm not sure when we will do another release for this. I have a couple of bug fixes + Rust edition upgrade that I want to merge, maybe another couple of stuff that some other people would like to get merge before we would do a release ; so if you are fine to pin the version by SHA, you can do so after we merge the PR, else you can subscribe to the tagpr PR #3124 to see when we do the release. Thanks for your contribution :) |
|
Hi @YJDoc2 thanks for the information. I'm okay to pin the SHA before the next release. |
YJDoc2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for your contribution :)
* bump nix to 0.29 Signed-off-by: Keming <[email protected]> * change to 0.29 for all Signed-off-by: Keming <[email protected]> --------- Signed-off-by: Keming <[email protected]>
* bump nix to 0.29 Signed-off-by: Keming <[email protected]> * change to 0.29 for all Signed-off-by: Keming <[email protected]> --------- Signed-off-by: Keming <[email protected]>
|
Hi @YJDoc2, it seems the dependabot still ignores nix. Can you check:
I guess those commands require the maintainer's permission to run. |
|
@dependabot show nix ignore conditions |
Hi @YJDoc2, I tried and found that this command only works in the PR created by the dependabot. (closed PR also works) |
Description
Hi. This is a version bump for nix.
The main reason is that I'm looking for a rust cgroups crate, the
libcgroupscould be the best one I can find that works and has been maintained well.However, the interface requires
fn add_task(&self, pid: Pid)bind to nix 0.28, which could be tricky to work with if users use other versions.So, I guess we can bump the version now. Later, maybe we could adjust the interface to make it more convenient for general purposes.
Type of Change
Testing
Related Issues
Fixes #
Additional Context