Skip to content

Conversation

@kemingy
Copy link
Contributor

@kemingy kemingy commented Mar 22, 2025

Description

Hi. This is a version bump for nix.

The main reason is that I'm looking for a rust cgroups crate, the libcgroups could be the best one I can find that works and has been maintained well.

However, the interface requires fn add_task(&self, pid: Pid) bind to nix 0.28, which could be tricky to work with if users use other versions.

So, I guess we can bump the version now. Later, maybe we could adjust the interface to make it more convenient for general purposes.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite
  • Tested manually (please provide steps)

Related Issues

Fixes #

Additional Context

kemingy added 2 commits March 22, 2025 11:46
Signed-off-by: Keming <[email protected]>
@YJDoc2 YJDoc2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 23, 2025
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 23, 2025

Hye @kemingy Thanks for the PR. overall looks good to me as no major code changes ; so should be good to merge if all CI passes. Strange that dependabot did not notify us for this. I guess I closed a PR for nix few versions ago due to breaking changes in nix, and dependabot must be ignoring all minor version updates due to that ; will need to see how we can fix it.

As you have mentioned that this is to be used in a project (seems pretty cool!) I would like to clarify that I'm not sure when we will do another release for this. I have a couple of bug fixes + Rust edition upgrade that I want to merge, maybe another couple of stuff that some other people would like to get merge before we would do a release ; so if you are fine to pin the version by SHA, you can do so after we merge the PR, else you can subscribe to the tagpr PR #3124 to see when we do the release.

Thanks for your contribution :)

@kemingy
Copy link
Contributor Author

kemingy commented Mar 23, 2025

Hi @YJDoc2 thanks for the information. I'm okay to pin the SHA before the next release.

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for your contribution :)

@YJDoc2 YJDoc2 merged commit 1b840bb into youki-dev:main Mar 24, 2025
28 of 29 checks passed
@kemingy kemingy deleted the nix29 branch March 24, 2025 04:39
@github-actions github-actions bot mentioned this pull request Mar 23, 2025
sou1118 pushed a commit to sou1118/youki that referenced this pull request Mar 26, 2025
* bump nix to 0.29

Signed-off-by: Keming <[email protected]>

* change to 0.29 for all

Signed-off-by: Keming <[email protected]>

---------

Signed-off-by: Keming <[email protected]>
sou1118 pushed a commit to sou1118/youki that referenced this pull request Mar 26, 2025
* bump nix to 0.29

Signed-off-by: Keming <[email protected]>

* change to 0.29 for all

Signed-off-by: Keming <[email protected]>

---------

Signed-off-by: Keming <[email protected]>
@kemingy
Copy link
Contributor Author

kemingy commented Oct 26, 2025

Hi @YJDoc2, it seems the dependabot still ignores nix. Can you check:

  • @dependabot show <dependency name> ignore conditions
  • @dependabot unignore <dependency name>

I guess those commands require the maintainer's permission to run.

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Oct 31, 2025

@dependabot show nix ignore conditions

@kemingy
Copy link
Contributor Author

kemingy commented Nov 3, 2025

@dependabot show nix ignore conditions

Hi @YJDoc2, I tried and found that this command only works in the PR created by the dependabot. (closed PR also works)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants