Don't expose bit flag operations quite so much to the user. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using 'bitflags' gives us the same internal representation but slightly more static type safety.
vext01
reviewed
Nov 27, 2020
| #[derive(Serialize, Deserialize)] | ||
| pub struct BodyFlags: u8 { | ||
| /// This function is annotated #[do_not_trace]. | ||
| const DO_NOT_TRACE = 0b00000001; |
Contributor
There was a problem hiding this comment.
can we use the 1<<X idiom? It's easier to read and less error prone.
Contributor
Author
There was a problem hiding this comment.
I used to use 1<<X but I've made too many mistakes with it to be fond of it any more. To be honest, I didn't think deeply about this: I think all of the examples you'll find using bitflags use the 0b notation, which suggests that's what people have gravitated towards.
Contributor
|
Just an easy comment. Looks good. |
Contributor
Author
|
@vext01 Does this PR need separate |
Contributor
|
bors r+ |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using 'bitflags' gives us the same internal representation but slightly more static type safety.