Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

Added users to federation#46

Merged
yitsushi merged 8 commits intoyitsushi:mainfrom
Skarlso:federation_v5
Oct 27, 2020
Merged

Added users to federation#46
yitsushi merged 8 commits intoyitsushi:mainfrom
Skarlso:federation_v5

Conversation

@Skarlso
Copy link
Copy Markdown
Contributor

@Skarlso Skarlso commented Oct 27, 2020

Summary

Adds users to Federation.

Related to #4.

@Skarlso
Copy link
Copy Markdown
Contributor Author

Skarlso commented Oct 27, 2020

something wrong with the linter again :/

@yitsushi
Copy link
Copy Markdown
Owner

  Error: 1-60 lines are duplicate of `services/federation/users_test.go:1-61` (dupl)
  Error: 1-61 lines are duplicate of `services/federation/instances_test.go:1-60` (dupl)

@yitsushi
Copy link
Copy Markdown
Owner

rebase from main, i added a golangci configuration file to ignore dupl (and a few others) in tests.

@yitsushi
Copy link
Copy Markdown
Owner

yitsushi commented Oct 27, 2020

The linter works as intended (ignore all the tar errors, not an issue, hope the will fix it, but it's there even if the PR passes the check. Scroll down and check teh results instead of all the tar errors. Fixed.

And you can always run the linter locally.

@yitsushi
Copy link
Copy Markdown
Owner

Please update the README too as this PR resolves #4

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 27, 2020

Coverage Status

Coverage increased (+0.7%) to 65.353% when pulling b1b251b on Skarlso:federation_v5 into cf0ecd5 on yitsushi:main.

@yitsushi yitsushi merged commit 2d3d828 into yitsushi:main Oct 27, 2020
@yitsushi yitsushi mentioned this pull request Oct 27, 2020
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants