Implements #reverse_each in Literal::Array
#299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hslzr
changed the title
#reverse_each#reverse_each in Literal::Array
Collaborator
|
Yeah, that will need to be addressed separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #194
I have a question about this method, though.
The Ruby docs for the
#reverse_eachmethod specifies that if no block is given, anEnumeratoris returned; otherwise, it returnsself.The current implementation of the
#eachmethod delegates the#eachcall to the@__value__, which in turn returns@__value__instead of the actualLiteral::Array. Is this by design or an oversight? I'm happy to address that in a separate PR if needed.I'm asking because I'm aware the implementation in this PR is different than the other methods.