chore: Add mutation testing workflow and configuration files.

.github/workflows/mutation.yml

@@ -0,0 +1,26 @@
+on:
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+
+  push:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+
+name: mutation test
+
+jobs:
+  mutation:
+    uses: php-forge/actions/.github/workflows/infection.yml@main
+    with:
+      phpstan: true
+    secrets:
+      STRYKER_DASHBOARD_API_KEY: ${{ secrets.STRYKER_DASHBOARD_API_KEY }}

composer.json

@@ -15,6 +15,7 @@
     },
     "require-dev": {
         "ext-simplexml": "*",
+        "infection/infection": "^0.27|^0.29",
         "maglnet/composer-require-checker": "^4.1",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan-strict-rules": "^2.0.3",
@@ -41,13 +42,15 @@
     "config": {
         "sort-packages": true,
         "allow-plugins": {
+            "infection/extension-installer": true,
             "phpstan/extension-installer": true,
             "yiisoft/yii2-composer": true
         }
     },
     "scripts": {
         "check-dependencies": "./vendor/bin/composer-require-checker check",
         "ecs": "./vendor/bin/ecs --fix",
+        "mutation": "./vendor/bin/infection --threads=4 --ignore-msi-with-no-mutations --only-covered --min-msi=100 --min-covered-msi=100",
         "rector": "./vendor/bin/rector process src",
         "static": "./vendor/bin/phpstan --memory-limit=512M",
         "tests": "./vendor/bin/phpunit"

infection.json.dist → infection.json5

@@ -1,16 +1,17 @@
 {
-    "source": {
-        "directories": [
-            "src"
-        ]
-    },
+    "$schema": "vendor/infection/infection/resources/schema.json",
     "logs": {
         "text": "php:\/\/stderr",
         "stryker": {
             "report": "main"
         }
     },
-    "mutators": {
-        "@default": true
-    }
+    "source": {
+        "directories": [
+            "src"
+        ]
+    },
+    "phpStan": {
+        "configDir": "."
+    },
 }

phpunit.xml.dist

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.2/phpunit.xsd"
+    xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
     bootstrap="tests/bootstrap.php"
     cacheDirectory="runtime/.phpunit.cache"
     colors="true"

src/NestedSetsQueryBehavior.php

@@ -86,7 +86,7 @@ public function leaves(): ActiveQuery
      *
      * Selects nodes where the left attribute equals `1`, indicating root nodes in the hierarchical structure.
      *
-     * If the model defines a primary key, the result is ordered by that attribute in ascending order.
+     * The result is ordered by the left attribute, and if the tree attribute is enabled, by the tree attribute as well.
      *
      * This method is useful for efficiently fetching all root nodes in single-tree or multi-tree scenarios managed by
      * the nested sets pattern.
@@ -105,14 +105,16 @@ public function roots(): ActiveQuery
     {
         $class = $this->getOwner()->modelClass;
         $model = new $class();
-        $sortAttribute = $model::primaryKey()[0] ?? null;
 
-        $activeQuery = $this->getOwner()->andWhere([$model->leftAttribute => 1]);
+        $columns = [$model->leftAttribute => SORT_ASC];
 
-        if ($sortAttribute !== null) {
-            $activeQuery->addOrderBy([$sortAttribute => SORT_ASC]);
+        if ($model->treeAttribute !== false) {
+            $columns = [$model->treeAttribute => SORT_ASC] + $columns;
         }
 
+        $activeQuery = $this->getOwner()->andWhere([$model->leftAttribute => 1]);
+        $activeQuery->addOrderBy($columns);
+
         return $activeQuery;
     }
 

tests/NestedSetsQueryBehaviorTest.php

@@ -75,20 +75,31 @@ public function testRootsMethodRequiresOrderByForCorrectTreeTraversal(): void
     {
         $this->createDatabase();
 
-        $rootD = new MultipleTree(['name' => 'Root D']);
-        $rootD->makeRoot();
-
-        $rootB = new MultipleTree(['name' => 'Root B']);
-        $rootB->makeRoot();
-
         $rootA = new MultipleTree(['name' => 'Root A']);
+
         $rootA->makeRoot();
 
         $rootC = new MultipleTree(['name' => 'Root C']);
+
         $rootC->makeRoot();
 
+        $rootB = new MultipleTree(['name' => 'Root B']);
+
+        $rootB->makeRoot();
+
+        $rootD = new MultipleTree(['name' => 'Root D']);
+
+        $rootD->makeRoot();
+        $command = $this->getDb()->createCommand();
+
+        $command->update('multiple_tree', ['tree' => 1], ['name' => 'Root A'])->execute();
+        $command->update('multiple_tree', ['tree' => 2], ['name' => 'Root B'])->execute();
+        $command->update('multiple_tree', ['tree' => 3], ['name' => 'Root C'])->execute();
+        $command->update('multiple_tree', ['tree' => 4], ['name' => 'Root D'])->execute();
+
         $rootsList = MultipleTree::find()->roots()->all();
-        $expectedOrder = ['Root D', 'Root B', 'Root A', 'Root C'];
+
+        $expectedOrder = ['Root A', 'Root B', 'Root C', 'Root D'];
 
         self::assertCount(
             4,
@@ -102,17 +113,11 @@ public function testRootsMethodRequiresOrderByForCorrectTreeTraversal(): void
                 $root,
                 "Root at index {$index} should be an instance of \'MultipleTree\'.",
             );
-            self::assertArrayHasKey(
-                $index,
-                $expectedOrder,
-                "Expected order array should have key at index {$index}.",
-            );
-
             if (isset($expectedOrder[$index])) {
                 self::assertEquals(
                     $expectedOrder[$index],
                     $root->getAttribute('name'),
-                    "Root at index {$index} should be {$expectedOrder[$index]} in correct \'id\' order.",
+                    "Root at index {$index} should be {$expectedOrder[$index]} in correct \'tree\' order.",
                 );
             }
         }