Conversation
udgover
reviewed
Jan 5, 2025
Collaborator
udgover
left a comment
udgover
left a comment
There was a problem hiding this comment.
Left some comments while waiting for the final review. Looks really cool!
udgover
reviewed
Jan 29, 2025
Collaborator
udgover
left a comment
udgover
left a comment
There was a problem hiding this comment.
Really nice PR! However, I've added several comments to be sure I've fully understood the inner working.
Besides, I'm wondering how search api endpoints should be handled regarding permissions. For a unique object endpoints (read, write, delete) it's handled with permissions decorator but search endpoints are not decorated. Do you confirm that for search we rely on database_arango.filter to do the job?
tomchop
added
enhancement
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.