Skip to content

fix(deno):tsc error and deno warnings #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcoe merged 3 commits into from
Nov 11, 2022
+6 −5
Merged

fix(deno):tsc error and deno warnings #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7456792
fix: TypeScript compiler error (Object is 'unknown')
rivy Oct 9, 2022
cefa53c
fix(build): use alternate rollup TS plugin to fix compilation failure
rivy Nov 4, 2022
fde0b61
fix(deno): specify deps (avoids Deno warnings)
rivy Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class Y18N {
err.message = 'syntax error in ' + languageFile
}

if (err.code === 'ENOENT') localeLookup = {}
if ((err as { code?: string }).code === 'ENOENT') localeLookup = {}
else throw err
}

Expand Down
4 changes: 2 additions & 2 deletions lib/platform-shims/deno.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* global Deno */

import { posix } from 'https://deno.land/std/path/mod.ts'
import { sprintf } from 'https://deno.land/std/fmt/printf.ts'
import { posix } from 'https://deno.land/std@0.159.0/path/mod.ts'
import { sprintf } from 'https://deno.land/std@0.159.0/fmt/printf.ts'

export default {
fs: {
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"prepare": "npm run compile"
},
"devDependencies": {
"@rollup/plugin-typescript": "^8.5.0",
"@types/node": "^14.6.4",
"@wessberg/rollup-plugin-ts": "^1.3.1",
"c8": "^7.3.0",
"chai": "^4.0.1",
"cross-env": "^7.0.2",
Expand All @@ -52,6 +52,7 @@
"rollup": "^2.26.10",
"standardx": "^7.0.0",
"ts-transform-default-export": "^1.0.2",
"tslib": "^2.4.1",
"typescript": "^4.0.0"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import ts from '@wessberg/rollup-plugin-ts'
import ts from '@rollup/plugin-typescript'
import transformDefaultExport from 'ts-transform-default-export'

const output = {
Expand Down