Skip to content

Windows/C89 compatibility #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2019
Merged

Windows/C89 compatibility #135

merged 2 commits into from
Mar 1, 2019

Conversation

@perlpunk
Copy link
Member

@perlpunk perlpunk commented Mar 1, 2019

We had some problems building PyYAML together with libyaml on appveyor Windows
(Microsoft Visual Studio 10.0)

Problem 1:

"C:\projects\pyyaml\libyaml\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\projects\pyyaml\libyaml\build\tests\run-dumper.vcxproj" (default target) (8) ->
(ClCompile target) ->
  ..\..\tests\run-dumper.c(83): error C2275: 'yaml_node_t' : illegal use of this type as an expression [C:\projects\pyyaml\libyaml\build\tests\run-dumper.vcxproj]
  ..\..\tests\run-dumper.c(83): error C2065: 'node1' : undeclared identifier [C:\projects\pyyaml\libyaml\build\tests\run-dumper.vcxproj]

Because a declaration comes after code.

Problem 2:

"C:\projects\pyyaml\libyaml\build\ALL_BUILD.vcxproj" (default target) (1) ->
"C:\projects\pyyaml\libyaml\build\tests\run-emitter-test-suite.vcxproj" (default target) (10) ->
  ..\..\tests\run-emitter-test-suite.c(5): fatal error C1083: Cannot open include file: 'stdbool.h': No such file or directory [C:\projects\pyyaml\libyaml\build\tests\run-emitter-test-suite.vcxproj]

So stdbool.h is not available.

This PR fixes both.

@perlpunk perlpunk requested a review from ingydotnet March 1, 2019 11:33
@perlpunk perlpunk merged commit 78e6ebf into master Mar 1, 2019
@perlpunk
Copy link
Member Author

perlpunk commented Mar 1, 2019

merged

@perlpunk perlpunk deleted the perlpunk/win branch March 1, 2019 22:08
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 1, 2019
@0-wiz-0
libyaml: update to 0.2.2.
7da9a2d 
Changes
=======

* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request Apr 11, 2019
Update to 0.2.2
5032905 
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Apr 11, 2019
Update to 0.2.2
6243592 
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Apr 11, 2019
Update to 0.2.2
5fadeab 
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name
kwm81 pushed a commit to freebsd/freebsd-ports-gnome that referenced this pull request Apr 13, 2019
@kwm81
Update to 0.2.2
26cebe9 
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name
swills pushed a commit to swills/freebsd-ports that referenced this pull request Apr 14, 2019
Update to 0.2.2
9a08b8d 
Fix portlint errors in Makefile

Changes in 0.2.2:
* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 19, 2019
@0-wiz-0
libyaml: update to 0.2.2.
aca1bfc 
Changes
=======

* yaml/libyaml#95 -- build: do not install config.h
* yaml/libyaml#97 -- appveyor.yml: fix Release build
* yaml/libyaml#103 -- Remove unused code in yaml_document_delete
* yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections
* yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c
* yaml/libyaml#117 -- Fix typo error
* yaml/libyaml#119 -- The closing single quote needs to be indented...
* yaml/libyaml#121 -- fix token name typos in comments
* yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar
* yaml/libyaml#125 -- Cherry-picks from PR 27
* yaml/libyaml#135 -- Windows/C89 compatibility
* yaml/libyaml#136 -- allow override of Windows static lib name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ingydotnet ingydotnet Awaiting requested review from ingydotnet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@perlpunk