Add Ctypes_memory.keep_alive function
#777
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose this function as Ctypes.keep_alive, and add documentation to the Ctypes.mli for it. In addition, remove the old `use_value` completely: from ctypes_roots.c, from cstubs_memory_stubs.ml. Add `Cstubs_internal.keep_alive` and change code-gen to use this instead of old `use_value`.
Author
|
Related to: #571 |
yallop
requested changes
Jul 29, 2024
| zero-filled. *) | ||
|
|
||
| val keep_alive : 'a -> unit | ||
| (** Inserting [keep_alive x;] in a sequence of expressions ensures that |
Owner
There was a problem hiding this comment.
Suggested change
| (** Inserting [keep_alive x;] in a sequence of expressions ensures that | |
| (** Inserting [keep_alive x] in a sequence of expressions ensures that |
|
|
||
| val keep_alive : 'a -> unit | ||
| (** Inserting [keep_alive x;] in a sequence of expressions ensures that | ||
| the garbage collector will not collect [x] until after that [keep_alive] |
Owner
There was a problem hiding this comment.
Suggested change
| the garbage collector will not collect [x] until after that [keep_alive] | |
| the garbage collector will not collect [x] until [keep_alive] |
Comment on lines
+208
to
+217
| let strchr = Foreign.foreign "strchr" (ptr char @-> char @-> returning (ptr char)) in | ||
| let p = CArray.of_string "abc" in | ||
| let q = strchr (CArray.start p) 'a' in | ||
| let () = Gc.compact () in | ||
| let () = Printf.printf "%c\n" !@q in | ||
| keep_alive p; | ||
| ]} | ||
| Without the [keep_alive p] at the bottom, [p] could be collected during the | ||
| [Gc.compact ()] call, which would make [q] an invalid pointer into the | ||
| now-collected [p], leading to undefined behavior. *) |
Owner
There was a problem hiding this comment.
This is a nice example, but I think it would be even stronger without the call to Gc.compact, because most programs don't call Gc functions.
| let q = strchr (CArray.start p) 'a' in | ||
| let () = Gc.compact () in | ||
| let () = Printf.printf "%c\n" !@q in | ||
| keep_alive p; |
Owner
There was a problem hiding this comment.
Suggested change
| keep_alive p; | |
| keep_alive p |
Comment on lines
+135
to
+137
| (* To avoid a dependence on Ctypes_memory, we redefine keep_alive here. *) | ||
| let keep_alive x = ignore (Sys.opaque_identity x) in | ||
| Gc.finalise (fun _ -> keep_alive src) ba; ba |
Owner
There was a problem hiding this comment.
Suggested change
| (* To avoid a dependence on Ctypes_memory, we redefine keep_alive here. *) | |
| let keep_alive x = ignore (Sys.opaque_identity x) in | |
| Gc.finalise (fun _ -> keep_alive src) ba; ba | |
| Gc.finalise (fun _ -> ignore (Sys.opaque_identity src)) ba; ba |
| (lang dune 2.9) | ||
| (name ctypes) | ||
| (version 0.22.0) | ||
| (version 0.23.0) |
Owner
There was a problem hiding this comment.
There's no need to change the version
| let () = Printf.printf "%c\n" !@q in | ||
| keep_alive p; | ||
| ]} | ||
| Without the [keep_alive p] at the bottom, [p] could be collected during the |
Owner
There was a problem hiding this comment.
Suggested change
| Without the [keep_alive p] at the bottom, [p] could be collected during the | |
| Without [keep_alive p], [p] could be collected during the |
| keep_alive p; | ||
| ]} | ||
| Without the [keep_alive p] at the bottom, [p] could be collected during the | ||
| [Gc.compact ()] call, which would make [q] an invalid pointer into the |
Owner
There was a problem hiding this comment.
Suggested change
| [Gc.compact ()] call, which would make [q] an invalid pointer into the | |
| [Gc.compact ()] call, making [q] an invalid pointer into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose this function as Ctypes.keep_alive, and add documentation to the Ctypes.mli for it. In addition, remove the old
use_valuecompletely: from ctypes_roots.c, from cstubs_memory_stubs.ml.Add
Cstubs_internal.keep_aliveand change code-gen to use this instead of olduse_value.