Skip to content

Conversation

@JurianArie
Copy link
Contributor

This PR undoes the deprecation of skipTotalRecords and restores the working of setTotalRecords(0) back to how it was in v10.4.3.

Alternative to #3169.
Partially reverts #3157.

@JurianArie JurianArie force-pushed the option-1-add-skip-total-records branch from 62d4271 to f3cb497 Compare August 22, 2024 16:47
@OzanKurt
Copy link
Contributor

I think bringing "skip" back is a great idea!

@sonarqubecloud
Copy link

@yajra
Copy link
Owner

yajra commented Aug 25, 2024

Looks good to go for me. Do you approve of this @OzanKurt?

@OzanKurt
Copy link
Contributor

My use case: (working)

I set my total records and it doesn't count them.

$dataTable->setTotalRecords($kpiValues['total_count']);

Case 1 • No Filtering

image

Case 2 • With Filtering

image

Jurian's use case: (working)

$dataTable->skipTotalRecords();

Case 1 • No Filtering

image

Case 2 • With Filtering

image


I think we have it now! 😊


Warning!

This might be a breaking change for people who is using setTotalRecords(0) instead of skipTotalRecords.

@yajra yajra merged commit 6530b75 into yajra:master Aug 26, 2024
@yajra
Copy link
Owner

yajra commented Aug 26, 2024

Released on https://github.com/yajra/laravel-datatables/releases/tag/v11.1.5 🚀 Thanks!

@JurianArie JurianArie deleted the option-1-add-skip-total-records branch August 26, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants