improve performance || is complex query #3133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove select param while checking because if we have complex subSelect query it will confuse the result. in simple query order is not important
Owner
|
Only a new line was added? Marked as a draft pr. |
Author
|
sorry that was only a test. |
yajra
requested changes
Apr 11, 2024
Owner
yajra
left a comment
yajra
left a comment
There was a problem hiding this comment.
Looking good, please please fix the failing tests?
|
Author
|
Hello @yajra, |
Owner
|
Reviewing PR #3135 and I think it aims for similar improvements with better backward compatibility and tests. Let's resume the discussion on that PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove select param while checking because if we have complex subSelect query it will confuse the result.
in simple query order is not important
Yes