Skip to content

fix: Prevent error when PHP extension iconv not enabled. #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yajra merged 2 commits into from
Nov 25, 2023
Merged

fix: Prevent error when PHP extension iconv not enabled. #3098

yajra merged 2 commits into from
Nov 25, 2023

Conversation

@sangnguyenplus
Copy link
Contributor

@sangnguyenplus sangnguyenplus commented Nov 25, 2023 •
edited
Loading

This PR will fix error when PHP extension iconv not enabled, so we can't use function iconv().

Call to undefined function Yajra\DataTables\iconv()
 {"userId":1,"exception":"[object] (Error(code: 0): Call to undefined function Yajra\\DataTables\\iconv() 
at .../vendor/yajra/laravel-datatables-oracle/src/QueryDataTable.php:867)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yajra yajra changed the title Prevent error when PHP extension iconv not enabled. fix: Prevent error when PHP extension iconv not enabled. Nov 25, 2023
@yajra yajra merged commit 928011e into yajra:master Nov 25, 2023
@yajra
Copy link
Owner

yajra commented Nov 25, 2023

Released on v10.11.1 🚀 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yajra yajra yajra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sangnguyenplus @yajra