Skip to content

Conversation

@mrezagolestan
Copy link
Contributor

this commit is about development not bug fix:

i realize a need to render column data for export, i found it by adding Export Class to set how to render export
but i couldn't find any thing for render print
and i need a centralized render for print & export (for simplicity & integrity)
so i added exportRender method to be used for pass a callback function to determine how targeted column data should be rendered for print & export, sample code is shown below:
Column::make('used')->title('Use Status')->exportRender(function($row,$data){return $data == 1 ? 'Yes' : 'Not Yet'});

but in this commit just method added and it should be paired to commit 56b94a4482f4273ce57b08b5cd05dbc695dfce22 in laravel-datatable-buttons repo to be pushed for calling callback function which is set in exportRender for rendering column data

please accept that pull request too after this pull request

@mrezagolestan
Copy link
Contributor Author

mrezagolestan commented May 7, 2023

#177 pull request should be accept after this pull request

@yajra
Copy link
Owner

yajra commented May 8, 2023

Looks good, can you please fix the failing checks?

…int + exports as expected: bugfix for static analysis with phpstan
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mrezagolestan
Copy link
Contributor Author

yeap
i'd been resolve it

@yajra yajra changed the title add exportRender method to be used in datatable-buttons for render pr… feat: add exportRender method to be used in datatable-buttons for render pr… Jul 31, 2023
@yajra yajra merged commit b60d761 into yajra:master Jul 31, 2023
@yajra
Copy link
Owner

yajra commented Jul 31, 2023

Apologies for the late review, released in v10.8.0 🚀 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants