-
Notifications
You must be signed in to change notification settings - Fork 26
Expand functionality: limit group for adapter #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand functionality: limit group for adapter #41
Conversation
|
Hi, @Envek. I done actualize and fixed failing specs. Running specs randomly is was a problem. |
Envek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request and sorry for the late reply. I will try to get to this in a few days.
| # Disable RSpec exposing methods globally on `Module` and `main` | ||
| config.disable_monkey_patching! | ||
|
|
||
| config.order = :random |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not good when test suite result depends on order in which tests are executed. These dependencies need to be detected and removed (maybe something need to be added to the Yabeda.reset!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it just solved my problem. Reverted it.
Envek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. There are some small tweaks and rewording needed, but otherwise it looks good.
lib/yabeda/dsl/class_methods.rb
Outdated
| else | ||
| return yield if block_given? | ||
|
|
||
| raise ConfigurationError, "Should be block passed with call .include_group for example" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That error message isn't very helpful because it doesn't tell what is wrong with this call to the adapter method and how to fix it.
Should be something like following, I think:
Yabeda.adaptershould be called either inside group declaration or should have block provided with a call toinclude_group. No metric group provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the message.
|
Thank you very much for your pull request and sorry for the long wait! Released in 0.14.0 |
Hey, @Envek. In continue my PR. I want to extend the metrics limit functionality for the adapter.
But specs do randomly green or red. For example:
What do you think about this? Thanks.