Skip to content

fix(gh-workflow): Lock Ubuntu runner to 22.04 as a temporary workaround for #75.#80

Merged
SharafMohamed merged 1 commit intoy-scope:mainfrom
SharafMohamed:lock-ubuntu-version
Feb 4, 2025
Merged

fix(gh-workflow): Lock Ubuntu runner to 22.04 as a temporary workaround for #75.#80
SharafMohamed merged 1 commit intoy-scope:mainfrom
SharafMohamed:lock-ubuntu-version

Conversation

@SharafMohamed
Copy link
Contributor

@SharafMohamed SharafMohamed commented Feb 1, 2025

Description

Validation performed

  • Existing tests pass on Git.

Summary by CodeRabbit

  • Chores
    • Updated the continuous integration workflow to specify Ubuntu 22.04 for build tasks, ensuring improved build consistency and accurate environment handling.

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2025

Walkthrough

The GitHub Actions workflow has been updated to run build jobs using Ubuntu 22.04 instead of the previous Ubuntu default. The alteration involves changing the job matrix OS value and updating the corresponding conditional logic for the Catch2 installation step. The overall job structure and other steps remain unchanged.

Changes

File Change Summary
.github/workflows/build.yaml Modified the job matrix to use "ubuntu-22.04" in place of "ubuntu-latest" and updated the condition for executing the Catch2 installation step accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant WA as Workflow Action
    participant JM as Job Matrix
    participant CS as Catch2 Script

    WA->>JM: Initiate build with OS options ["macos-latest", "ubuntu-22.04"]
    alt OS is "ubuntu-22.04"
         JM->>CS: Run Catch2 installation script
    else OS is "macos-latest"
         JM->>WA: Skip Catch2 installation
    end
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e08f728 and 4d911af.

📒 Files selected for processing (1)
  • .github/workflows/build.yaml (2 hunks)
🔇 Additional comments (2)
.github/workflows/build.yaml (2)

31-33: Matrix OS Configuration Updated to Ubuntu 22.04.

The update to the os array (["macos-latest", "ubuntu-22.04"]) correctly locks the Ubuntu version to 22.04. This change aligns perfectly with the PR objective to prevent the compiler errors on Ubuntu 24.04 associated with the fmt library.


42-44: Conditional Update for Catch2 Installation on Ubuntu.

The condition has been updated to if: "matrix.os == 'ubuntu-22.04'", which ensures the Catch2 installation script is executed only on Ubuntu 22.04. This change is consistent with the modified OS matrix and meets the PR requirements.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@LinZhihao-723 LinZhihao-723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

fix(gh-workflow): Lock Ubuntu runner to 22.04 as a temporary workaround for #75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants