test: Add a DFA test case for a capture group with repetition; Deduplicate DFA test code.

[SharafMohamed]

Description

Add DFA tests for:

• Repetition case: "([a]+=(?1+),)+",

Clean up existing tests to be more concise.

Validation performed

New tests run successfully.

Summary by CodeRabbit

• Tests
  • Simplified and unified DFA test cases with a new helper function for easier testing.
  • Added a new test case for repetition patterns with tagged captures.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The test suite for DFA serialization was refactored to use a new helper function that constructs DFAs from schema strings internally, serializes them, and compares the output to expected results. All test cases were updated to use this function, and a new test for repetition with tagged captures was added.

Changes

File(s)	Change Summary
tests/test-dfa.cpp	Replaced compare_serialized_dfa with test_dfa that builds DFAs from schema strings and compares serialization. Updated all test cases to use the new function. Added a new test for repetition with tagged captures.

Sequence Diagram(s)

sequenceDiagram
    participant TestCase
    participant test_dfa
    participant Schema
    participant NFA
    participant DFA

    TestCase->>test_dfa: Call with schema strings, expected output
    test_dfa->>Schema: Construct and add variables from schema strings
    test_dfa->>Schema: Extract schema AST
    test_dfa->>NFA: Create lexical rules from schema variables
    test_dfa->>NFA: Build NFA from rules
    test_dfa->>DFA: Convert NFA to DFA
    test_dfa->>DFA: Serialize DFA
    test_dfa->>TestCase: Compare serialized output to expected

Loading

Possibly related PRs

• refactor: Move epsilon_closure from Lexer to NfaState; Refactor nfa_to_dfa as Dfa's constructor. #71: Refactors internal DFA construction logic, moving core DFA conversion functions between classes, which relates to this PR's focus on DFA construction and serialization in test code.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[SharafMohamed]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.