Skip to content
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f71fc32
Bump Catch2 from 2.13.7 to 3.8.0
Bill-hbrhbr Jun 8, 2025
8e6c2c3
Update doc
Bill-hbrhbr Jun 8, 2025
356d8ce
Merge branch 'main' into bump-catch2
Bill-hbrhbr Jun 8, 2025
2a0e544
Avoid string_view comparison for Catch2
Bill-hbrhbr Jun 8, 2025
3ffe2c1
Typo fix
Bill-hbrhbr Jun 9, 2025
41469dd
Add Catch2 v3 StringMaker specialization for string view
Bill-hbrhbr Jun 9, 2025
9565583
misc fixes
Bill-hbrhbr Jun 9, 2025
9cb0dc1
Include Catch2 tostring header if necessary
Bill-hbrhbr Jun 9, 2025
aa89d38
Compile catch2 with c++20 standard for string_view comparisons
Bill-hbrhbr Jun 10, 2025
a29b119
Apply suggestions from code review
Bill-hbrhbr Jun 10, 2025
8200462
Merge branch 'main' into bump-catch2
Bill-hbrhbr Jun 10, 2025
30a0552
Merge branch 'main' into bump-catch2
Bill-hbrhbr Aug 15, 2025
c4e8941
Merge branch 'main' into bump-catch2
Bill-hbrhbr Aug 15, 2025
99a7d45
Remove unnecessary cmake gen arg
Bill-hbrhbr Aug 15, 2025
e64c497
Address coderabbit ai comments
Bill-hbrhbr Aug 15, 2025
68f40a4
Revert remove cmake gen args
Bill-hbrhbr Aug 15, 2025
92adb3c
Merge branch 'main' into bump-catch2
Bill-hbrhbr Aug 18, 2025
96d574d
Update taskfiles/deps/main.yaml
Bill-hbrhbr Aug 18, 2025
8dbceee
Merge branch 'main' into bump-catch2
Bill-hbrhbr Aug 18, 2025
008c612
Update components/core/tests/test-string_utils.cpp
Bill-hbrhbr Aug 18, 2025
1e08414
Update components/core/tests/test-string_utils.cpp
Bill-hbrhbr Aug 18, 2025
1a73bf2
Merge branch 'main' into bump-catch2
Bill-hbrhbr Aug 18, 2025
407a530
null commit
Bill-hbrhbr Aug 18, 2025
9c3da07
null commit
Bill-hbrhbr Aug 18, 2025
35227b2
Merge branch 'main' into bump-catch2
Bill-hbrhbr Aug 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions components/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,8 @@ if(CLP_NEED_BOOST)
endif()

if(CLP_NEED_CATCH2)
find_package(Catch2 REQUIRED)
if (Catch2_FOUND)
message(STATUS "Found Catch2 ${Catch2_VERSION}")
endif()
find_package(Catch2 3.8.0 REQUIRED)
message(STATUS "Found Catch2 ${Catch2_VERSION}")
endif()

if(CLP_NEED_DATE)
Expand Down Expand Up @@ -717,7 +715,6 @@ set(SOURCE_FILES_unitTest
tests/test-ir_parsing.cpp
tests/test-ir_serializer.cpp
tests/test-kql.cpp
tests/test-main.cpp
tests/test-math_utils.cpp
tests/test-MemoryMappedFile.cpp
tests/test-NetworkReader.cpp
Expand Down Expand Up @@ -749,7 +746,7 @@ if(CLP_BUILD_TESTING)
PRIVATE
absl::flat_hash_map
Boost::filesystem Boost::iostreams Boost::program_options Boost::regex Boost::url
Catch2::Catch2
Catch2::Catch2WithMain
${CURL_LIBRARIES}
clp_s::search::ast
clp_s::search::kql
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
#include <utility>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <fmt/core.h>
#include <fmt/format.h>
#include <ystdlib/error_handling/Result.hpp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
#include <utility>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_template_test_macros.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <fmt/core.h>
#include <nlohmann/json_fwd.hpp>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
#include <utility>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <catch2/generators/catch_generators_range.hpp>

#include "../../../../../clp_s/search/ast/BooleanLiteral.hpp"
#include "../../../../../clp_s/search/ast/ColumnDescriptor.hpp"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include <utility>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <msgpack.hpp>
#include <ystdlib/error_handling/Result.hpp>

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/clp_s_test_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#include <string>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp_s/ArchiveWriter.hpp"
#include "../src/clp_s/InputConfig.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-BoundedReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#include <string>
#include <string_view>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/BoundedReader.hpp"
#include "../src/clp/ErrorCode.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-BufferedFileReader.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <array>

#include <boost/filesystem.hpp>
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/BufferedFileReader.hpp"
#include "../src/clp/FileReader.hpp"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include <unistd.h>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/EncodedVariableInterpreter.hpp"
#include "../src/clp/ir/types.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-FileDescriptorReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#include <string_view>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <ystdlib/containers/Array.hpp>

#include "../src/clp/FileDescriptorReader.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-GlobalMetadataDBConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include <boost/program_options/options_description.hpp>
#include <boost/program_options/parsers.hpp>
#include <boost/program_options/variables_map.hpp>
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/GlobalMetadataDBConfig.hpp"

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-GrepCore.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include <string>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <log_surgeon/Lexer.hpp>
#include <log_surgeon/SchemaParser.hpp>

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-MemoryMappedFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#include <filesystem>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/FileReader.hpp"
#include "../src/clp/ReaderInterface.hpp"
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-NetworkReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
#include <unordered_map>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <curl/curl.h>
#include <fmt/core.h>
#include <nlohmann/json.hpp>
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-ParserWithUserSchema.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
#include <utility>

#include <boost/filesystem.hpp>
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/matchers/catch_matchers.hpp>
#include <log_surgeon/LogParser.hpp>
#include <log_surgeon/SchemaParser.hpp>

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-SQLiteDB.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <utility>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <fmt/core.h>
#include <fmt/format.h>

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-Segment.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <unistd.h>

#include <boost/filesystem.hpp>
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/streaming_archive/reader/Segment.hpp"
#include "../src/clp/streaming_archive/writer/Segment.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-Stopwatch.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include <unistd.h>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/Stopwatch.hpp"

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-StreamingCompression.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <utility>

#include <boost/filesystem/operations.hpp>
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <ystdlib/containers/Array.hpp>
#include <zstd.h>

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-TimestampPattern.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/TimestampPattern.hpp"

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-Utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#include <boost/foreach.hpp>
#include <boost/range/combine.hpp>
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/Utils.hpp"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
#include <string_view>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>

#include "../src/clp_s/archive_constants.hpp"
#include "../src/clp_s/ArchiveReader.hpp"
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-clp_s-end_to_end.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
#include <string_view>
#include <utility>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <fmt/format.h>

#include "../src/clp_s/CommandLineArguments.hpp"
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-clp_s-range_index.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
#include <string>
#include <string_view>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <fmt/format.h>
#include <msgpack.hpp>
#include <nlohmann/json.hpp>
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-clp_s-search.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
#include <utility>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <fmt/format.h>
#include <nlohmann/json.hpp>

Expand Down
4 changes: 3 additions & 1 deletion components/core/tests/test-encoding_methods.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#include <catch2/catch.hpp>
#include <catch2/catch_template_test_macros.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>

#include "../src/clp/ffi/encoding_methods.hpp"
#include "../src/clp/ir/types.hpp"
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-ffi_IrUnitHandlerReq.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
#include <string_view>
#include <utility>

#include <catch2/catch.hpp>
#include <catch2/catch_template_test_macros.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/ffi/ir_stream/decoding_methods.hpp"
#include "../src/clp/ffi/ir_stream/IrUnitHandlerReq.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-ffi_KeyValuePairLogEvent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <variant>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <nlohmann/json.hpp>
#include <nlohmann/json_fwd.hpp>

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-ffi_SchemaTree.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <msgpack.hpp>

#include "../src/clp/ffi/SchemaTree.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-hash_utils.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <string_view>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/ErrorCode.hpp"
#include "../src/clp/hash_utils.hpp"
Expand Down
4 changes: 3 additions & 1 deletion components/core/tests/test-ir_encoding_methods.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
#include <utility>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_template_test_macros.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <msgpack.hpp>
#include <nlohmann/json.hpp>

Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-ir_parsing.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/ir/parsing.hpp"
#include "../src/clp/ir/types.hpp"
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-ir_serializer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
#include <string>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_template_test_macros.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/ffi/ir_stream/decoding_methods.hpp"
#include "../src/clp/ir/constants.hpp"
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-kql.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
#include <string>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <fmt/core.h>
#include <spdlog/spdlog.h>

Expand Down
2 changes: 0 additions & 2 deletions components/core/tests/test-main.cpp

This file was deleted.

2 changes: 1 addition & 1 deletion components/core/tests/test-math_utils.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/math_utils.hpp"

Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-query_methods.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include <unordered_map>

#include <catch2/catch.hpp>
#include <catch2/catch_template_test_macros.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp/ffi/encoding_methods.hpp"
#include "../src/clp/ffi/search/ExactVariableToken.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-regex_utils.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include <string>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <regex_utils/ErrorCode.hpp>
#include <regex_utils/regex_translation_utils.hpp>
#include <regex_utils/RegexToWildcardTranslatorConfig.hpp>
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-sql.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include <memory>
#include <sstream>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>

#include "../src/clp_s/search/ast/EmptyExpr.hpp"
#include "../src/clp_s/search/sql/sql.hpp"
Expand Down
2 changes: 1 addition & 1 deletion components/core/tests/test-string_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#include <boost/foreach.hpp>
#include <boost/range/combine.hpp>
#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <string_utils/string_utils.hpp>

using clp::string_utils::clean_up_wildcard_search_string;
Expand Down
3 changes: 2 additions & 1 deletion components/core/tests/test-utf8_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
#include <string_view>
#include <vector>

#include <catch2/catch.hpp>
#include <catch2/catch_test_macros.hpp>
#include <catch2/generators/catch_generators.hpp>
#include <nlohmann/json.hpp>

#include "../src/clp/ffi/utils.hpp"
Expand Down
2 changes: 1 addition & 1 deletion docs/src/dev-guide/components-core/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ The task will download, build, and install (within the build directory) the foll
|-----------------------------------------------------------------------|----------------|
| [abseil-cpp](https://github.com/abseil/abseil-cpp) | 20250512.0 |
| [ANTLR](https://www.antlr.org) | v4.13.2 |
| [Catch2](https://github.com/catchorg/Catch2.git) | v2.13.7 |
| [Catch2](https://github.com/catchorg/Catch2.git) | v3.8.0 |
| [date](https://github.com/HowardHinnant/date.git) | v3.0.1 |
| [fmt](https://github.com/fmtlib/fmt) | v10.2.1 |
| [json](https://github.com/nlohmann/json.git) | v3.11.3 |
Expand Down
Loading
Loading