Skip to content

Conversation

@Bill-hbrhbr
Copy link
Contributor

@Bill-hbrhbr Bill-hbrhbr commented Jun 7, 2025

Description

Bump the version of yscope-dev-utils to introduce the following changes that affect the usage of task yscope-dev-utils:cmake:install-remote-tar:

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Dep install taskflows complete successfully.

Summary by CodeRabbit

  • Chores
    • Updated the version of the yscope-dev-utils dependency.
    • Improved configuration structure and variable naming for dependency installation tasks to enhance clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 7, 2025

Walkthrough

This update modifies dependency management scripts and taskfiles, specifically reorganizing and renaming variables related to CMake-based library installation tasks. It also updates the commit hash references for the yscope-dev-utils subproject and its download script to a newer version, aligning all related configurations.

Changes

File(s) Change Summary
taskfiles/deps/main.yaml Replaced NAME with CMAKE_PACKAGE_NAME in the antlr-runtime task variables; removed NAME from subtask.
taskfiles/deps/utils.yaml Consolidated and renamed variables for CMake install tasks; grouped under CMAKE_GEN_ARGS for clarity.
tools/scripts/deps-download/init.sh, tools/yscope-dev-utils Updated yscope-dev-utils commit hash from 2693d8b... to 76aecbd....

Possibly related PRs

Suggested reviewers

  • davidlion

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db6d7a2 and 7739250.

📒 Files selected for processing (4)
  • taskfiles/deps/main.yaml (1 hunks)
  • taskfiles/deps/utils.yaml (1 hunks)
  • tools/scripts/deps-download/init.sh (1 hunks)
  • tools/yscope-dev-utils (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: ubuntu-jammy-dynamic-linked-bins
  • GitHub Check: ubuntu-jammy-lint
  • GitHub Check: centos-stream-9-static-linked-bins
  • GitHub Check: centos-stream-9-dynamic-linked-bins
  • GitHub Check: ubuntu-jammy-static-linked-bins
  • GitHub Check: build-macos (macos-14, true)
🔇 Additional comments (4)
tools/yscope-dev-utils (1)

1-1:

✅ Verification successful

Verify updated subproject commit SHA consistency

The yscope-dev-utils subproject commit SHA has been bumped to 76aecbd6d0db6e2078005431946b5c2e716c4291. Please ensure that all references to the old SHA (2693d8b69050b8d48f96ae60cfce7be8626d3875) have been replaced across scripts and taskfiles.


🏁 Script executed:

#!/bin/bash
# Check for stale references to the old commit SHA and verify the new SHA is present.

old="2693d8b69050b8d48f96ae60cfce7be8626d3875"
new="76aecbd6d0db6e2078005431946b5c2e716c4291"

echo "🔍 Searching for old SHA..."
if rg -l "$old"; then
  echo "❌ Found stale references to old SHA"
  exit 1
else
  echo "✅ No stale references to old SHA"
fi

echo "🔍 Verifying new SHA presence..."
if rg -l "$new"; then
  echo "✅ New SHA referenced in files"
else
  echo "❌ New SHA not found"
  exit 1
fi

Length of output: 511


✔ Commit SHA updated successfully and validated

No instances of the old SHA (2693d8b69050b8d48f96ae60cfce7be8626d3875) remain. The new SHA (76aecbd6d0db6e2078005431946b5c2e716c4291) is referenced in:
• tools/scripts/deps-download/init.sh

All references are consistent; no further changes needed.

taskfiles/deps/main.yaml (1)

167-167: Add CMAKE_PACKAGE_NAME to CMake install call
The new yscope-dev-utils version expects CMAKE_PACKAGE_NAME instead of the old NAME variable. This change aligns the yscope-dev-utils:cmake:install task with the updated parameter naming.

tools/scripts/deps-download/init.sh (1)

13-13:

✅ Verification successful

Bump YSCOPE_DEV_UTILS_COMMIT_SHA to new version
Updated the commit SHA to 76aecbd6d0db6e2078005431946b5c2e716c4291 to match the subproject bump in tools/yscope-dev-utils.

Run the following script to confirm the commit exists in the remote repo:


🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail
sha="76aecbd6d0db6e2078005431946b5c2e716c4291"
status=$(curl -s -o /dev/null -w "%{http_code}" \
  "https://api.github.com/repos/y-scope/yscope-dev-utils/commits/$sha")
if [ "$status" -ne 200 ]; then
  echo "❌ Commit $sha not found in y-scope/yscope-dev-utils"
  exit 1
fi
echo "✅ Commit $sha verified"

Length of output: 373


✅ Approved bump of YSCOPE_DEV_UTILS_COMMIT_SHA
The commit SHA 76aecbd6d0db6e2078005431946b5c2e716c4291 in tools/scripts/deps-download/init.sh has been verified in the y-scope/yscope-dev-utils repository. No further changes required.

taskfiles/deps/utils.yaml (1)

66-72: Consolidate and rename CMake install parameters
The install-remote-cmake-lib task now feeds CMAKE_GEN_ARGS, CMAKE_JOBS, CMAKE_PACKAGE_NAME, CMAKE_SETTINGS_DIR, TAR_SHA256, and TAR_URL into yscope-dev-utils:cmake:install-remote-tar, replacing the legacy flat variables. This refactor matches the updated subproject interface and clarifies variable grouping.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Bill-hbrhbr Bill-hbrhbr changed the title Bump yscope dev utils build(deps-dev): Bump yscope-dev-utils to include changes to yscope-dev-utils:cmake:install-remote-tar's parameters. Jun 8, 2025
@Bill-hbrhbr Bill-hbrhbr marked this pull request as ready for review June 8, 2025 21:12
@Bill-hbrhbr Bill-hbrhbr requested a review from a team as a code owner June 8, 2025 21:12
@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion June 10, 2025 05:10
@davidlion davidlion changed the title build(deps-dev): Bump yscope-dev-utils to include changes to yscope-dev-utils:cmake:install-remote-tar's parameters. build(deps-dev): Bump yscope-dev-utils and apply breaking changes to yscope-dev-utils:cmake tasks' parameters. Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants