build(taskfile): Add tasks to run clang-tidy and to run non-C++ linting; Move C++ linting tasks into the clp-core build GH workflows.

.github/workflows/clp-core-build-macos.yaml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - ".github/workflows/clp-core-build-macos.yaml"
+      - ".gitmodules"
       - "components/core/cmake/**"
       - "components/core/CMakeLists.txt"
       - "components/core/src/**"
@@ -17,6 +18,7 @@ on:
   push:
     paths:
       - ".github/workflows/clp-core-build-macos.yaml"
+      - ".gitmodules"
       - "components/core/cmake/**"
       - "components/core/CMakeLists.txt"
       - "components/core/src/**"
@@ -47,6 +49,8 @@ jobs:
     steps:
       - uses: "actions/checkout@v4"
         with:
+          # Fetch history so that the `clang-tidy-diff` task can compare against the main branch.
+          fetch-depth: 0
           submodules: "recursive"
 
       # See https://github.com/actions/setup-python/issues/577
@@ -78,3 +82,9 @@ jobs:
           --build-dir build
           --num-jobs $(getconf _NPROCESSORS_ONLN)
           --test-spec "~[Stopwatch]"
+
+      # TODO: When enough files are passing clang-tidy, switch to a full pass on schedule only.
+      # - run: >-
+      #     task lint:check-cpp-${{(github.event_name == 'schedule') && 'full' || 'diff'}}
+      - run: "task lint:check-cpp-full"
+        shell: "bash"

.github/workflows/clp-core-build.yaml

@@ -301,3 +301,36 @@ jobs:
           push: true
           tags: "${{steps.core_image_meta.outputs.tags}}"
           labels: "${{steps.core_image_meta.outputs.labels}}"
+
+  ubuntu-jammy-lint:
+    # Run if the ancestor jobs succeeded OR they were skipped and clp was changed.
+    if: >-
+      success()
+      || (!cancelled() && !failure() && needs.filter-relevant-changes.outputs.clp_changed == 'true')
+    needs:
+      - "filter-relevant-changes"
+      - "ubuntu-jammy-deps-image"
+    runs-on: "ubuntu-latest"
+    steps:
+      - uses: "actions/checkout@v4"
+        with:
+          # Fetch history so that the `clang-tidy-diff` task can compare against the main branch.
+          fetch-depth: 0
+          submodules: "recursive"
+
+      - name: "Work around actions/runner-images/issues/6775"
+        run: "chown $(id -u):$(id -g) -R ."
+        shell: "bash"
+
+      - uses: "./.github/actions/run-on-image"
+        env:
+          OS_NAME: "ubuntu-jammy"
+        with:
+          image_name: "${{env.DEPS_IMAGE_NAME_PREFIX}}${{env.OS_NAME}}"
+          use_published_image: >-
+            ${{needs.filter-relevant-changes.outputs.ubuntu_jammy_image_changed == 'false'
+            || (github.event_name != 'pull_request' && github.ref == 'refs/heads/main')}}
+          # TODO: When enough files are passing clang-tidy, switch to a full pass on schedule only.
+          # run_command: >-
+          #   task lint:check-cpp-${{(github.event_name == 'schedule') && 'full' || 'diff'}}
+          run_command: "task lint:check-cpp-full"

.github/workflows/clp-lint.yaml

@@ -38,4 +38,4 @@ jobs:
 
       - name: "Run lint task"
         shell: "bash"
-        run: "task lint:check"
+        run: "task lint:check-no-cpp"

Taskfile.yml

@@ -185,28 +185,37 @@ tasks:
           INCLUDE_PATTERNS: ["{{.OUTPUT_DIR}}"]
 
   core:
-    vars:
-      SRC_DIR: "{{.ROOT_DIR}}/components/core"
-    sources:
+    cmds:
+      - task: "core-generate"
+      - task: "core-build"
+
+  core-generate:
+    internal: true
+    sources: &core_source_files
       - "{{.G_DEPS_CORE_CHECKSUM_FILE}}"
-      - "{{.SRC_DIR}}/cmake/**/*"
-      - "{{.SRC_DIR}}/CMakeLists.txt"
-      - "{{.SRC_DIR}}/src/**/*"
+      - "{{.G_CORE_COMPONENT_DIR}}/cmake/**/*"
+      - "{{.G_CORE_COMPONENT_DIR}}/CMakeLists.txt"
+      - "{{.G_CORE_COMPONENT_DIR}}/src/**/*"
       - "{{.TASKFILE}}"
       - "/etc/os-release"
+    deps: ["deps:core"]
+    cmds:
+      - task: "utils:cmake:generate"
+        vars:
+          BUILD_DIR: "{{.G_CORE_COMPONENT_BUILD_DIR}}"
+          SOURCE_DIR: "{{.G_CORE_COMPONENT_DIR}}"
+
+  core-build:
+    internal: true
+    sources: *core_source_files
     generates:
       - "{{.G_CORE_COMPONENT_BUILD_DIR}}/clg"
       - "{{.G_CORE_COMPONENT_BUILD_DIR}}/clo"
       - "{{.G_CORE_COMPONENT_BUILD_DIR}}/clp"
       - "{{.G_CORE_COMPONENT_BUILD_DIR}}/clp-s"
       - "{{.G_CORE_COMPONENT_BUILD_DIR}}/indexer"
       - "{{.G_CORE_COMPONENT_BUILD_DIR}}/reducer-server"
-    deps: ["deps:core", "init"]
     cmds:
-      - task: "utils:cmake:generate"
-        vars:
-          BUILD_DIR: "{{.G_CORE_COMPONENT_BUILD_DIR}}"
-          SOURCE_DIR: "{{.SRC_DIR}}"
       - task: "utils:cmake:build"
         vars:
           BUILD_DIR: "{{.G_CORE_COMPONENT_BUILD_DIR}}"

components/core/tools/scripts/lib_install/centos-stream-9/install-prebuilt-packages.sh

@@ -19,4 +19,5 @@ dnf install -y \
     make \
     mariadb-connector-c-devel \
     openssl-devel \
+    python3-pip \
     xz-devel

components/core/tools/scripts/lib_install/ubuntu-jammy/install-prebuilt-packages.sh

@@ -24,4 +24,5 @@ DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y \
   pkg-config \
   python3 \
   python3-pip \
+  python3-venv \
   software-properties-common

docs/src/dev-guide/contributing-linting.md

@@ -2,7 +2,7 @@
 
 Before submitting a PR, ensure you've run our linting tools and either fixed any violations or
 suppressed the warning. If you can't run the linting workflows locally, you can enable and run the
-[clp-lint] workflow in your fork.
+[clp-lint] and [clp-core-build] workflows in your fork.
 
 ## Requirements
 
@@ -32,5 +32,6 @@ task lint:fix
 ```
 
 [clp-lint]: https://github.com/y-scope/clp/blob/main/.github/workflows/clp-lint.yaml
+[clp-core-build]: https://github.com/y-scope/clp/blob/main/.github/workflows/clp-core-build.yaml
 [feature-req]: https://github.com/y-scope/clp/issues/new?assignees=&labels=enhancement&projects=&template=feature-request.yml
 [Task]: https://taskfile.dev/

lint-requirements.txt

@@ -1,4 +1,5 @@
 black>=24.4.2
 clang-format>=20.1
+clang-tidy>=19.1
 ruff>=0.4.4
 yamllint>=1.35.1